Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The $generichide modifier prevents URL blocking rules from working correctly #2690

Open
alexx7311 opened this issue Jan 17, 2024 · 5 comments

Comments

@alexx7311
Copy link

AdGuard Extension version

4.3.4

Browser version

Chrome 121

OS version

Windows 11

What filters do you have enabled?

AdGuard Base filter, AdGuard Social Media filter

What Stealth Mode options do you have enabled?

No response

Issue Details

STR:

  1. Disable all filters except for Base filter and Social media filter.
  2. Go to https://www.espaebook2.com/book/cuentos-del-inventor-de-respuestas-2/
  3. Open filtering log and check if the rule https://platform.twitter.com/widgets/tweet_button.html?count=vertical&url=https://www.espaebook2.com/book/cuentos-del-inventor-de-respuestas-2/ exists.
Screenshot from 4.1.57

Screenshot

Expected Behavior

No response

Screenshots

Screenshot 1:

Additional Information

No response

@Alex-302
Copy link
Member

One more case at http://matomelotte.com/tag/%E6%BE%A4%E6%9D%91%E6%8B%93%E4%B8%80

https://www.facebook.com/plugins/like.php?href=http%3A%2F%2Fmatomelotte.com is not blocked if added @@||facebook.com^$generichide

The rule, which should block that request
||facebook.com/plugins/$domain=~facebook.com|~freepresets.com

@Yuki2718
Copy link

Yuki2718 commented Jan 25, 2024

I suggest @@||facebook.com^$generichide,badfilter as a temp workaround, though probably the problem will happen with other rules too. @@||facebook.com^$generichide was added to potentially defuse their anti-adb, but no filter author has confirmed it actually works.

@Alex-302
Copy link
Member

Alex-302 commented Jan 25, 2024

It's better to wait. The new version (4.4) should be released soon.

@krystian3w
Copy link

krystian3w commented Jan 31, 2024

Worse if there is no solution in planned  Version: AdGuard v4.4 And it will be carried over to releases  Version: AdGuard v4.5 or  https://github.com/AdguardTeam/AdguardBrowserExtension/labels/Version%3A%20AdGuard%20v4%2E6 (or his patches/hotfixes).

Alex-302 added a commit to AdguardTeam/AdguardFilters that referenced this issue Mar 14, 2024
@alexx7311
Copy link
Author

Similar issue #2757

@adguard-bot adguard-bot assigned maximtop and stanislav-atr and unassigned 105th and maximtop Mar 28, 2024
Iz-zzzzz added a commit to Iz-zzzzz/IzFilter-Public that referenced this issue Jun 9, 2024
- drop a support for AdGuard (Waiting for issues to be resolved)
See more: 
1. $generichide modifier prevents other rules($doc, network request .etc) to work correctly - AdguardTeam/AdguardBrowserExtension#2690
2. AdGuard on Firefox doesn't parse filters inside an !#if cap_html_filtering directive of custom rules (but User rule does) - AdguardTeam/AdguardBrowserExtension#2259
3. Some of HTML Filtering rules can break site - AdguardTeam/AdguardBrowserExtension#2646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants