Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been looking for a while to reduce the footprint of the logs on my machine, while still keeping them.
this pr is the start of that work, and does the following:
my idea is that one could implement the "Store" and "Searcher" interfaces for different sorts of storage and indexing backends.
This would allow people to create their own log storage & search implementations. looking at #2290, it seems that people are eager to have custom log sinks, but the existing implementation makes it hard to add a new one.
I think more thought needs to be put into an actual interface, along with the configuration format, but I do not feel like the qualified person to do that. so my goal in this PR was mostly to keep compatibility with the existing logging implementation, keeping the changes simple. hopefully we can move from here to something better. that said, things have to start somewhere, so I thought I would make the PR anyways.
new to this project, so if i did anything wrong, please let me know. happy to make any changes / take any suggestions