Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SafeSearch does not work for Google #576

Closed
mveplus opened this issue Feb 6, 2019 · 1 comment
Closed

SafeSearch does not work for Google #576

mveplus opened this issue Feb 6, 2019 · 1 comment
Assignees
Milestone

Comments

@mveplus
Copy link

mveplus commented Feb 6, 2019

Google safe search is not applied when "safesearch_enabled: true" and using default upstream_dns.
Running latest offical version: v0.92-hotfix2
Local address: 192.168.0.254:53

Steps to reproduce

  1. Grab binary archive
  2. Extract and run as root, listening on :53, 3000
  3. Navigate to the web interface and turn on Enforce SafeSearch
  4. dig or nslookup should return Google VIP or CNAME

Expected behavior

Google will serve SafeSearch Search and Image Search results for requests that we receive on this VIP.

Actual behavior

Looking at the results ( DNS queries) no SafeSearch Search and Image Search is applied.

All family protections ticket on under General settings:
nslookup www.google.com 176.103.130.132
Server: 176.103.130.132
Address: 176.103.130.132#53
Name: www.google.com
Address: 216.239.38.120

nslookup www.google.com 192.168.0.254
Server: 192.168.0.254
Address: 192.168.0.254#53
Non-authoritative answer:
Name: www.google.com
Address: 216.58.206.132

Only Enforce SafeSearch ticket on under General settings:
nslookup www.google.com 192.168.0.254
Server: 192.168.0.254
Address: 192.168.0.254#53
Non-authoritative answer:
Name: www.google.com
Address: 172.217.23.36

nslookup www.google.com 176.103.130.132
Server: 176.103.130.132
Address: 176.103.130.132#53
Name: www.google.com
Address: 216.239.38.120

Your environment

Proxmox - LXC container Debian GNU/Linux 8 (jessie)

Description Value
Version of AdGuard Home server: (v0.92-hotfix2 )
How did you setup DNS configuration: System and Router,
Upstream DNS servers - default AdGuard Home server tls://
If it's a router or IoT, please write device model: Dell Vostro 460
Operating system and version: Debian GNU/Linux 8 (jessie)

If I do change Upstream DNS servers in AdGuard Home Settings to AdGuard Family shield .132/.133 it works.

@ameshkov ameshkov added this to the v0.93 milestone Feb 6, 2019
@ameshkov
Copy link
Member

ameshkov commented Feb 6, 2019

Confirmed, thank you!

@ameshkov ameshkov assigned admitrevskiy and unassigned hmage Feb 18, 2019
ameshkov added a commit that referenced this issue Feb 25, 2019
* commit '86279f19b0b5bce37a83c05c88511fb82441c730':
  Add TODO
  Fix merge issues
  Add stats assertions
  Add safesearch test for dnsforward
  Use go tools
  Fix #576 - Fix safesearch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants