Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream DNS servers do not support Chinese domain names #2915

Open
3 tasks done
banbendalao opened this issue Apr 3, 2021 · 7 comments
Open
3 tasks done

Upstream DNS servers do not support Chinese domain names #2915

banbendalao opened this issue Apr 3, 2021 · 7 comments
Assignees
Labels
bug external libs Issues that require changes in external libraries. P3: Medium
Milestone

Comments

@banbendalao
Copy link

Have a question or an idea? Please search it on our forum to make sure it was not yet asked. If you cannot find what you had in mind, please submit it here.

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Issue Details

  • Version of AdGuard Home server:
    v0.106.0-a.95+2a435601
  • How did you install AdGuard Home:
    Github releases
  • How did you setup DNS configuration:
    System
  • If it's a router or IoT, please write device model:
  • CPU architecture:
    AMD64
  • Operating system and version:
    Debian10

Expected Behavior

Support Chinese domain names

Actual Behavior

Fill in Upstream DNS servers
[/恒天.com/]223.5.5.5
Will not be able to start AdGuardHome

@ainar-g
Copy link
Contributor

ainar-g commented Apr 5, 2021

This is a bug, thanks for reporting! In the meantime, please try using the punycode version:

[/xn--rss99n.com/]223.5.5.5

@ainar-g ainar-g added this to the v1.0.0 milestone Apr 5, 2021
adguard pushed a commit that referenced this issue Apr 7, 2021
Updates #2915.

Squashed commit of the following:

commit b907324
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Apr 7 16:26:41 2021 +0300

    all: imp docs, upd

commit c022f75
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Apr 7 15:51:30 2021 +0300

    all: add idna handling, imp domain validation
@Aikatsui
Copy link
Contributor

Aikatsui commented Apr 27, 2021

@ainar-g related issue,
https://en.wikipedia.org/wiki/List_of_Internet_top-level_domains#Internationalized_country_code_top-level_domains
https://en.wikipedia.org/wiki/List_of_Internet_top-level_domains#Internationalized_generic_top-level_domains

Currently UI (including query log) display only punnycode for language specific domain names and extensions, it makes uncomfortable due necessary to use converter for recognize them and as russian characters more familiar to you than english then i believe each script especially beneficial for particular users.
But users may fail to recognize eg: latin script uses languages (between english and spanish) domain names properly then it's better to add "punnycode" field to "request details" component.

image

@ainar-g
Copy link
Contributor

ainar-g commented Apr 27, 2021

@Aikatsui, thanks for the requests. I've filed #3012 for the backend part about the search and also #3013 for the frontend part about showing decoded domain names.

@fernvenue
Copy link
Contributor

@Aikatsui, thanks for the requests. I've filed #3012 for the backend part about the search and also #3013 for the frontend part about showing decoded domain names.

Actually this issue still exists in upstream_dns_file, please check it again, thank you so much.

@ainar-g
Copy link
Contributor

ainar-g commented Aug 3, 2021

@fernvenue, this issue isn't closed yet, so we know it still exists. Unfortunately, the issue spans multiple packages, so we won't be able to fix it as quickly as we would like.

@ainar-g ainar-g added the external libs Issues that require changes in external libraries. label Aug 3, 2021
@fernvenue
Copy link
Contributor

@fernvenue, this issue isn't closed yet, so we know it still exists. Unfortunately, the issue spans multiple packages, so we won't be able to fix it as quickly as we would like.

Thank you for letting me know, I'll wait patiently and keep paying attention. Perhaps it's a good idea to comment this in the configuration at the moment? Because #3013 the frontend part of the display decoding domain is normal, this may make people mistakenly think that it works normally in upstream_dns_file.

@ainar-g
Copy link
Contributor

ainar-g commented Aug 10, 2021

@fernvenue, thanks for the suggestion and sorry about the late response. We've mentioned the bug on the wiki page about configuration: https://github.com/AdguardTeam/AdGuardHome/wiki/Configuration#upstreams-from-file.

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
Updates AdguardTeam#2915.

Squashed commit of the following:

commit b907324
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Apr 7 16:26:41 2021 +0300

    all: imp docs, upd

commit c022f75
Author: Ainar Garipov <A.Garipov@AdGuard.COM>
Date:   Wed Apr 7 15:51:30 2021 +0300

    all: add idna handling, imp domain validation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug external libs Issues that require changes in external libraries. P3: Medium
Projects
None yet
Development

No branches or pull requests

4 participants