AdGuard redesign tracking issue / checklist

[ameshkov]

It may be necessary to consult this issue: #2075

This issue just contains a checklist of pages that we implement (see "client2").

• Initial setup
• Login
• Dashboard
  • Add charts for protocol and/or DNS request types
  • Update UI -- no date picker for now
• Setup guide - part 1 (before review)
• Setup guide - part 2 (after review)
• DNS blocklists
• DNS whitelists
• DNS rewrites, including editing and several records for one pattern
• Blocked services
• Custom filtering rules
• Settings -> General settings
• Settings -> DNS settings
• Settings -> Encryption
• Settings -> Client settings
  • Show a mark if a client blocked in the DNS settings
• Settings -> DHCP
• Query log
• Global notifications
  • New version is available
  • Certificate is about to expire

[Blakhard]

For now, we can not make date picker on Dashboard due to API.

[ameshkov]

@Blakhard yep, np, this feature will be moved to a future version.

[Blakhard]

1. Now "Blocked ads" and "Blocked trackers" are combined to "Blocked by filters".
2. No chart data for "Average processing time"
3. "Internal server statistic" block can not be done, appear in next API releases.
4. "Server uptime" in header, unclear is it server uptime, or machine uptime.

[ameshkov]

@Blakhard we'll have to implement these in this version so some changes to the backend will be necessary.

Implement a stub for now.

[WildByDesign]

@ameshkov Does this redesign implementation allow the potential for adding Dark Mode to UI elements?

Since you are at the beginning of the implementation and design stage for this, I figured I should bring this up. Dark Mode continues to be one of the most up-voted feature requests.

Thank you for all of the great work that your team does. Despite the whole Covid-19 slowing down much of the world, your team kept on rocking it without slowing down. Cheers!

[ameshkov]

Yep, I guess once the redesign is completed, we'll be able to bring the dark mode soon after that

[Aikatsui]

@ameshkov Is it possible to try #481 (comment) ?
(I know, already has many issues to address but very difficult to work with query log to view time series data)

[ameshkov]

Well, I'd better do that later, we already planned too much on this redesign.

[ainar-g]

#3066 proposes adding autoupdate of the query log as well.

[gregtwallace]

For the dashboard and charts, have you guys considered a more broad and user controllable scheme for the graphs? That is, I was looking at refactoring the code so any rule (whether DNS blacklist, blocked service, or custom rule) would have a user selectable option for the type of content being blocked (e.g. based on the current graphs: Ads, Malicious, and Content) and then possibly even a sub-type (e.g. Ads ->Trackers, Malicious -> Abuse, Malicious -> AdGuard Security Service, Content -> Pornography, Content -> AdGuard Parental Control) and maybe even make the sub-type a user editable field rather than drop down.

Basically this would make the reporting customizable so the user can define and then see what type of content is being blocked and drill further into a graph to look at the sub-types of content. This would be advanced functionality but existing filter lists could just be crafted to have a pre-defined type/sub-type so "regular" users don't have to do any extra work compared to the current setup.

I was contemplating a refactor to make this work but didn't want to dive down that hole if you guys already planned something like this or were going a different direction.

• I realize this would also impact the Query Log filtering, but I suspect the same improvement could be carried over to that.

[ncodee]

Sorry to ask, but it's been a while, and wanted to ask if the development had come to an hault, or it just hasn't been updated here?

[ainar-g]

@ncodee, we're currently developing it in a private repo, as there is a lot to do, and some details still need polishing. We currently predict that it will land during the v0.108 cycle.

[ainar-g]

#3725 proposes to make all modal windows never close if the user has changed some data without saving it.