Skip to content

Conversation

@C-Achard
Copy link
Collaborator

@C-Achard C-Achard commented Jul 12, 2023

Trying to raise coverage as much as possible by adding more unit tests and ignoring code that should not be tested (external mainly)

Arguably, since the dev_scripts folder is not used in plugin code, it could be ignored. It raises coverage slightly, but if it does make it into the plugin it'll have to be tested (especially code from #41).
Reach 90% before merging ? With the new PRs we'll see later

@C-Achard C-Achard self-assigned this Jul 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #42 (d2fa556) into main (a1e363e) will increase coverage by 9.72%.
The diff coverage is 83.41%.

@@            Coverage Diff             @@
##             main      #42      +/-   ##
==========================================
+ Coverage   72.33%   82.06%   +9.72%     
==========================================
  Files          50       43       -7     
  Lines        5209     4594     -615     
==========================================
+ Hits         3768     3770       +2     
+ Misses       1441      824     -617     
Impacted Files Coverage Δ
...ri_cellseg3d/code_models/models/model_SegResNet.py 77.77% <ø> (+5.05%) ⬆️
...ri_cellseg3d/code_models/models/wnet/soft_Ncuts.py 100.00% <ø> (+37.68%) ⬆️
napari_cellseg3d/code_plugins/plugin_metrics.py 63.93% <ø> (-0.30%) ⬇️
...ri_cellseg3d/code_plugins/plugin_model_training.py 69.97% <0.00%> (+2.38%) ⬆️
napari_cellseg3d/code_plugins/plugin_base.py 68.39% <13.33%> (-0.17%) ⬇️
napari_cellseg3d/code_models/workers.py 71.79% <33.33%> (+9.09%) ⬆️
...i_cellseg3d/code_plugins/plugin_model_inference.py 71.94% <46.37%> (+9.36%) ⬆️
napari_cellseg3d/code_models/model_framework.py 85.96% <77.77%> (+30.51%) ⬆️
napari_cellseg3d/_tests/test_models.py 97.10% <89.47%> (-2.90%) ⬇️
napari_cellseg3d/_tests/test_utils.py 96.77% <93.44%> (-3.23%) ⬇️
... and 14 more

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@C-Achard C-Achard marked this pull request as draft July 13, 2023 09:20
C-Achard added 9 commits July 13, 2023 11:21
Fix ONNX reqs
Disable dev scripts coverage
Tests :
    - Base plugin
    - ONNX inference
    - Cropping
Fixes :
    - Fixed review image loading not working
    - Fixed scaling when running inference on a folder and showing originals
@C-Achard C-Achard marked this pull request as ready for review July 14, 2023 09:33
@C-Achard C-Achard requested review from CYHSM and MMathisLab July 14, 2023 09:33
@MMathisLab
Copy link
Member

lgtm!

@C-Achard C-Achard merged commit b60b2be into main Jul 27, 2023
@C-Achard C-Achard deleted the cy/tests branch December 5, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants