Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Tab not respecting background clearing #185

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

Morphexe
Copy link
Contributor

@Morphexe Morphexe commented Sep 20, 2023

This fixes #183, although I am not 100% sure if this is the correct approach.

Copy link
Owner

@Adanos020 Adanos020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for fixing this! I like how simple this is.

There is an even nicer way to do this: instead of making the fill color transparent, you can just replace the call to .rect with .rect_stroke and remove the color argument.

@Adanos020 Adanos020 merged commit beeacab into Adanos020:main Sep 20, 2023
@Morphexe
Copy link
Contributor Author

Yeah, I am still learning the libs around, and I wasn`t sure of what I was doing - literally picked up rust yesterday lol.

@Adanos020
Copy link
Owner

You're clearly doing great since you've been able to identify and fix the issue rather quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear background broken?
2 participants