Skip to content

Fix/transaction types #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Fix/transaction types #14

merged 2 commits into from
Oct 9, 2023

Conversation

martiliones
Copy link
Collaborator

This way tools for generating types will know we are using constants

// before
interface SpecificTransaction {
  type: number
}

// after
interface SpecificTransaction {
  type: 1
}

@martiliones martiliones requested a review from bludnic October 9, 2023 10:30
@martiliones martiliones merged commit a6dc329 into master Oct 9, 2023
@martiliones martiliones deleted the fix/transaction-types branch October 9, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants