fix: layout fixes #782
Open
fix: layout fixes #782
+122
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Deployed to https://msg-adamant-pr-782.surge.sh 🚀 |
skranee
requested changes
Apr 30, 2025
| @@ -104,6 +104,9 @@ export default { | |||
| } | |||
| }, | |||
| methods: { | |||
There was a problem hiding this comment.
May be convert this file to composition? It seems like it's going to be fast
| /> | ||
| </container> | ||
| </v-row> | ||
| </component> | ||
| </template> | ||
|
|
||
| <script> |
There was a problem hiding this comment.
This one too, doesn't seem hard to convert to composition
| @@ -206,7 +207,13 @@ export default { | |||
| CurrencySwitcher, | |||
| PasswordSetDialog | |||
| }, | |||
| mixins: [scrollPosition], | |||
There was a problem hiding this comment.
You transported the scrollbar position logic to mounted, right?
| props: { | ||
| sidebarLayoutRef: { | ||
| type: Object, | ||
| required: false, |
bludnic
reviewed
May 1, 2025
Comment on lines
+230
to
+242
| mounted() { | ||
| nextTick(() => { | ||
| if (this.sidebarLayoutRef) { | ||
| const scrollTopValue = Number(localStorage.getItem('optionsScrollTop')) || 0 | ||
| this.sidebarLayoutRef.scrollTo({ | ||
| top: scrollTopValue | ||
| }) | ||
| } | ||
| }) | ||
| }, | ||
| beforeUnmount() { | ||
| localStorage.setItem('optionsScrollTop', this.sidebarLayoutRef?.scrollTop || 0) | ||
| }, |
There was a problem hiding this comment.
Why you store the scroll position in the LocalStorage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.