Skip to content

feat: update Android app icon #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2025
Merged

feat: update Android app icon #776

merged 1 commit into from
May 4, 2025

Conversation

Linhead
Copy link
Collaborator

@Linhead Linhead commented Apr 25, 2025

No description provided.

@Linhead Linhead requested a review from a team as a code owner April 25, 2025 14:31
Copy link

vercel bot commented Apr 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
adamant-im ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2025 2:31pm

@Linhead
Copy link
Collaborator Author

Linhead commented Apr 25, 2025

Copy link

Deployed to https://msg-adamant-pr-776.surge.sh 🚀

@adamantmm
Copy link
Member

adamantmm commented Apr 28, 2025

@Linhead
Please explain why splash files are also changed.

image

@Linhead
Copy link
Collaborator Author

Linhead commented Apr 28, 2025

@Linhead Please explain why splash files are also changed.

image

@adamantmm There is a android:generate-assets in package.json file which is supposed to use for generating graphic assets for android. As far as I grasp this command launches script which takes all files from folder capacitor/assets and generate the files for android app. Since besides file with the new icon there are splash.png and splash-dark.png files in the capacitor/assets folder the script has generated the new files for android app from this files also. That's why the splash files has been changed as well. But their visual appearance has stayed completely the same. Nevertheless for code purity I think it will be better to remove changed splash files from current commit as they appearance hasn't changed and leave just icon files.

@bludnic
Copy link
Member

bludnic commented May 2, 2025

Nevertheless for code purity I think it will be better to remove changed splash files from current commit as they appearance hasn't changed and leave just icon files.

Let's do it @Linhead

@bludnic bludnic merged commit 954bba4 into dev May 4, 2025
3 checks passed
@bludnic bludnic deleted the feat/update-android-app-icon branch May 4, 2025 02:46
Copy link

github-actions bot commented May 4, 2025

Successfully tore down https://msg-adamant-pr-776.surge.sh 🥲

@S-FrontendDev S-FrontendDev mentioned this pull request May 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants