Skip to content

feat: placeholder in a new chat #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 20 commits into
base: dev
Choose a base branch
from

Conversation

skranee
Copy link
Collaborator

@skranee skranee commented Apr 16, 2025

Lmk if you have any suggestions guys
https://trello.com/c/ukeJHNFi/

@skranee skranee requested a review from a team as a code owner April 16, 2025 18:20
Copy link

vercel bot commented Apr 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
adamant-im ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 30, 2025 2:24pm

@skranee skranee changed the title feat: display getting public key in chatroom feat: placeholder in a new chat Apr 16, 2025
@skranee skranee requested review from adamantmm and bludnic April 16, 2025 18:22
Copy link

github-actions bot commented Apr 16, 2025

Deployed to https://msg-adamant-pr-765.surge.sh 🚀

Copy link
Collaborator

@NikIvv NikIvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

I'd prefer not mixing up Composition and Options API, unless the Chats.vue is already planned to be changed into Composition API style in one of the latter commits.

@skranee
Copy link
Collaborator Author

skranee commented Apr 21, 2025

image

I'd prefer not mixing up Composition and Options API, unless the Chats.vue is already planned to be changed into Composition API style in one of the latter commits.

It's changed to composition here
#746

@adamant-al
Copy link
Member

@skranee
Please update.

@skranee
Copy link
Collaborator Author

skranee commented Apr 24, 2025

Chats.vue is still in options API, we need to merge this one first #746 (here Chats.vue is in composition and with resolved conflicts), so then I'll quickly convert it to composition.

@adamantmm
Copy link
Member

@skranee
#746 is merged

@skranee
Copy link
Collaborator Author

skranee commented Apr 29, 2025

1 similar comment
@skranee
Copy link
Collaborator Author

skranee commented Apr 29, 2025

@skranee
Copy link
Collaborator Author

skranee commented Apr 30, 2025

It seems like the only thing left to do is to fix this weird bug with scrollbar, for now I have absolutely no idea why this happens and how to fix this little thing even though I've spent hours on trying to discover that. If you have any suggestions - I'd be highly greatful for them because I consider that bug annoying and worth of being fixed unless Alexey (@adamant-al) tells the opposite and desides that this bug is not a priority right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants