Integration with ADAMANT Notification Service #658
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Deployed to https://msg-adamant-pr-658.surge.sh 🚀 |
bludnic
changed the title
| const { type, payload } = mutation | ||
| if (type === 'chat/setFulfilled' && payload) { | ||
| getCurrentAccount().then((account) => { | ||
| const pk = account.privateKey |
There was a problem hiding this comment.
const { privateKey } = account
There was a problem hiding this comment.
it's just a syntactic sugar.
There was a problem hiding this comment.
The point here is about shortname pk. It's not clear what does it mean. Better to use privateKey
There was a problem hiding this comment.
As of now none of the plugins are in .ts, that small plugin in js should not be an issue for now.
There was a problem hiding this comment.
It doesn't matter. You can import TS in JS, the configuration allow this
| data: function () { | ||
| return { | ||
| passwordDialog: false, | ||
| selectedNotificationValue: 0, | ||
| notificationItems: [ | ||
| { title: 'No Notifications', value: notificationType['No Notifications'] }, | ||
| { title: 'Background Fetch', value: notificationType['Background Fetch'] }, | ||
| { title: 'Push', value: notificationType['Push'] } | ||
| ], | ||
| showInfo: true, | ||
| infoText: this.$t('options.notifications_info') | ||
| } | ||
| }, |
There was a problem hiding this comment.
what purpose for function?
let's move new vars to setup hook
There was a problem hiding this comment.
@NikIvv Please don't resolve the conversation until it's fixed
There was a problem hiding this comment.
Ok, I did not notice it has been already changed.
New notification service https://github.com/adamant-im/adamant-ns
Created the PR just to trigger the build.