Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding FeedViewModel. #562

Merged
merged 5 commits into from
Nov 26, 2024
Merged

Adding FeedViewModel. #562

merged 5 commits into from
Nov 26, 2024

Conversation

AdamMc331
Copy link
Owner

Summary

Testing if we want to begin a migration off of Circuit and using VMs and Compose Navigation, since that's what I might be more familiar with. Still keeping circuit instances for now, going to build screen level VMs in parallel.

How It Was Tested

Need to add unit tests for VM but otherwise fine since unreferenced.

Copy link

github-actions bot commented Nov 26, 2024

Warnings
⚠️ Please add labels to this PR.
Messages
📖 Thanks @AdamMc331!
📖

The following dependencies have later milestone versions:

Failed to determine the latest version for the following dependencies (use --info for details):

  • app.cash.turbine:turbine
    1.2.0
  • com.apollographql.apollo3:apollo-runtime
    3.8.5
  • com.google.testing.platform:android-driver-instrumentation
  • com.google.testing.platform:android-test-plugin
  • com.google.testing.platform:core
  • com.google.testing.platform:launcher
  • com.google.testparameterinjector:test-parameter-injector
    1.18
  • com.russhwolf:multiplatform-settings-no-arg
    1.2.0
  • com.slack.circuit:circuit-foundation
    0.25.0
  • com.squareup.okio:okio
    3.9.1
  • com.squareup.sqldelight:coroutines-extensions
    1.5.5
  • com.squareup.sqldelight:native-driver
    1.5.5
  • com.squareup.sqldelight:runtime
    1.5.5
  • com.varabyte.truthish:truthish
    1.0.2
  • de.cketti.unicode:kotlin-codepoints
    0.9.0
  • io.insert-koin:koin-core
    4.0.0
  • io.ktor:ktor-client-cio
    3.0.1
  • io.ktor:ktor-client-content-negotiation
    3.0.1
  • io.ktor:ktor-client-core
    3.0.1
  • io.ktor:ktor-client-ios
    3.0.1
  • io.ktor:ktor-client-logging
    3.0.1
  • io.ktor:ktor-client-mock
    3.0.1
  • io.ktor:ktor-client-serialization
    3.0.1
  • io.ktor:ktor-serialization-kotlinx-json
    3.0.1
  • org.jetbrains.androidx.lifecycle:lifecycle-viewmodel
    2.8.4
  • org.jetbrains.compose.foundation:foundation
    1.7.1
  • org.jetbrains.compose.material:material-icons-extended
    1.7.1
  • org.jetbrains.compose.material3:material3
    1.7.1
  • org.jetbrains.compose.runtime:runtime
    1.7.1
  • org.jetbrains.kotlin:kotlin-stdlib
    2.0.21-488
  • org.jetbrains.kotlinx:kotlinx-coroutines-core
    1.9.0
  • org.jetbrains.kotlinx:kotlinx-coroutines-test
    1.9.0
  • org.jetbrains.kotlinx:kotlinx-datetime
    0.6.1
  • org.jetbrains.kotlinx:kotlinx-serialization-json
    1.7.3
  • org.jsoup:jsoup
    1.18.1
  • org.mobilenativefoundation.store:store5
    5.0.0

Gradle current updates:

  • Gradle: [8.11.1: UP-TO-DATE]

Generated by 🚫 Danger Kotlin against 7504daf

Comment on lines +73 to +76
.map { eventList ->
eventList.map(Event::toSummaryDisplayModel)
}
.map(EventGroupDisplayModel.Companion::mapFromEventList)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mapping can probably go into the use case.

@AdamMc331 AdamMc331 merged commit e0d2775 into development Nov 26, 2024
6 of 7 checks passed
@AdamMc331 AdamMc331 deleted the arm-feed-vm branch November 26, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant