[Bug Fix] Adding Check for SP During User Role Assignment. (microsoft#1497)

nharper285 · chkeita · web-flow · commit 5e3d915dc74c · 2021-11-30T20:19:29.000-08:00
* Adding check for SP during user role assignment.

* Fixing formatting.

* Fixing condition.

* Update src/deployment/deploy.py

Co-authored-by: Cheick Keita &lt;kcheick@gmail.com&gt;

* Formatting.

Co-authored-by: Cheick Keita &lt;kcheick@gmail.com&gt;
diff --git a/src/deployment/deploy.py b/src/deployment/deploy.py
@@ -613,6 +613,9 @@ def assign_scaleset_identity_role(self) -> None:
         )
 
     def assign_user_access(self) -> None:
+        if self.upgrade:
+            logger.info("Upgrading: Skipping assignment of current user to app role")
+            return
         logger.info("assinging user access to service principal")
         app = get_application(
             display_name=self.application_name,

Original file line number	Diff line number	Diff line change
`@@ -613,6 +613,9 @@ def assign_scaleset_identity_role(self) -> None:`
`613`	`613`	`)`
`614`	`614`
`615`	`615`	`def assign_user_access(self) -> None:`
	`616`	`+ if self.upgrade:`
	`617`	`+ logger.info("Upgrading: Skipping assignment of current user to app role")`
	`618`	`+ return`
`616`	`619`	`logger.info("assinging user access to service principal")`
`617`	`620`	`app = get_application(`
`618`	`621`	`display_name=self.application_name,`