Google Maps 9.1.1 #43
Conversation
|
@AdamEssenmacher Fixed merge conflicts. |
|
Perfect, thanks! I'll get to reviewing the remaining parts of the PR shortly. |
AdamEssenmacher
left a comment
AdamEssenmacher
left a comment
There was a problem hiding this comment.
I think we're 99% of the way there! I think I only spotted one actual error. The rest of my comments either ask to not move code around unnecessarily, to avoid unnecessarily changing the existing API surface, and to use the .NET naming convention for 'Id'.
I'm really excited to be able to bring this in soon. Great work!
|
@AdamEssenmacher PR comments should be fixed. |
|
Excellent. I checked a test build using the sample app from a port of Xamarin.Forms.GoogleMaps and everything looked good! If you'd be interested in joining this project as a contributor, I'll send you and invite. For a contribution like this, I'd be happy to add you to the FUNDING.yml too :) |
Adam, I think this would be great opportunity for me to give back to the .NET community next to the packages I already try to maintain once in a while (https://www.nuget.org/profiles/Digifais) 😉. Let's try and put some work in this repo to bring more packages up to date! |
|
Awesome! I'll send you an invite shortly. If you want to send me an email at hello@scavos.com maybe we can exchange Discords? I'm really happy to see those Facebook bindings too. They've been on my list for a long while. Are there public repos for them? |
Email has been sent out to you a couple of hours ago with my Discord. Public repos are not set up yet for the Facebook bindings, I'll try and make work out of that soon. |
2 participants
This PR aims to bump GoogleMaps to v9.1.1, this should close #31.
Note: there have been a few minor automatic formatting changes by the IDE. 🤷