-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1048: Use signed integers for storage #1051
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BTW, sorry for the missing cleanup (e.g. black, mypy etc) and random commit message. This is meant as a basis for discussion. I will cleanup if we want this. |
treiher
requested changes
May 27, 2022
|
treiher
requested changes
Jun 9, 2022
kanigsson
force-pushed
the
issue_1048
branch
9 times, most recently
from
June 16, 2022 08:35
4eee67f
to
9f06846
Compare
kanigsson
force-pushed
the
issue_1048
branch
2 times, most recently
from
June 16, 2022 08:58
f06fd42
to
8ebad8b
Compare
Also fixes #974 |
treiher
requested changes
Jun 17, 2022
kanigsson
force-pushed
the
issue_1048
branch
4 times, most recently
from
June 20, 2022 01:10
4e74028
to
1de3342
Compare
treiher
requested changes
Jun 20, 2022
kanigsson
force-pushed
the
issue_1048
branch
2 times, most recently
from
June 21, 2022 08:30
24c37e5
to
78c3049
Compare
to improve provability
treiher
requested changes
Jun 23, 2022
treiher
approved these changes
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1048
This commit proves with wavefront except for one check: