Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1048: Use signed integers for storage #1051

Merged
merged 19 commits into from
Jun 27, 2022
Merged

Issue 1048: Use signed integers for storage #1051

merged 19 commits into from
Jun 27, 2022

Conversation

kanigsson
Copy link
Collaborator

@kanigsson kanigsson commented May 24, 2022

Closes #1048

This commit proves with wavefront except for one check:

rflx-in_ipv4_tests.adb:186:13: medium: precondition might fail, cannot prove RFLX_Types.To_Length (Available_Space (Ctx, F_Payload)) >= Length
  186 |            Set_Payload (UDP_Datagram_Context, 18);
      |            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

@kanigsson
Copy link
Collaborator Author

BTW, sorry for the missing cleanup (e.g. black, mypy etc) and random commit message. This is meant as a basis for discussion. I will cleanup if we want this.

defaults.gpr Outdated Show resolved Hide resolved
rflx/templates/rflx_arithmetic.ads Outdated Show resolved Hide resolved
rflx/templates/rflx_arithmetic.ads Outdated Show resolved Hide resolved
defaults.gpr Show resolved Hide resolved
@kanigsson
Copy link
Collaborator Author

kanigsson commented Jun 9, 2022

In particular the name change of Terminating into Always_Return makes the patch fail for all older tools. This was an issue only for the old SPARK version, now updated.

rflx/templates/rflx_arithmetic.ads Outdated Show resolved Hide resolved
@kanigsson kanigsson force-pushed the issue_1048 branch 9 times, most recently from 4eee67f to 9f06846 Compare June 16, 2022 08:35
@kanigsson kanigsson force-pushed the issue_1048 branch 2 times, most recently from f06fd42 to 8ebad8b Compare June 16, 2022 08:58
@kanigsson kanigsson requested a review from treiher June 16, 2022 09:07
@kanigsson
Copy link
Collaborator Author

Also fixes #974

@kanigsson kanigsson linked an issue Jun 16, 2022 that may be closed by this pull request
@kanigsson kanigsson changed the title Issue 1048 Issue 1048: Use signed integers for storage Jun 16, 2022
examples/apps/ping/src/icmpv4.adb Outdated Show resolved Hide resolved
tests/property/strategies.py Show resolved Hide resolved
rflx/templates/rflx_builtin_types-conversions.ads Outdated Show resolved Hide resolved
@kanigsson kanigsson force-pushed the issue_1048 branch 4 times, most recently from 4e74028 to 1de3342 Compare June 20, 2022 01:10
@kanigsson kanigsson requested a review from treiher June 20, 2022 07:01
tests/property/strategies.py Outdated Show resolved Hide resolved
rflx/generator/generator.py Outdated Show resolved Hide resolved
@kanigsson kanigsson force-pushed the issue_1048 branch 2 times, most recently from 24c37e5 to 78c3049 Compare June 21, 2022 08:30
rflx/const.py Outdated Show resolved Hide resolved
@kanigsson kanigsson requested a review from treiher June 23, 2022 09:57
@kanigsson kanigsson linked an issue Jun 24, 2022 that may be closed by this pull request
@kanigsson kanigsson merged commit 711e284 into main Jun 27, 2022
@kanigsson kanigsson deleted the issue_1048 branch June 27, 2022 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants