Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers: Katie and Sara #8

Open
wants to merge 62 commits into
base: master
Choose a base branch
from
Open

Ampers: Katie and Sara #8

wants to merge 62 commits into from

Conversation

kcforsman
Copy link

Video Store Consumer

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Paste a link to the PR for your API Ada-C9/VideoStoreConsumer-API#6
For each person in your pair, describe something you learned from your partner during this project Different ways to solve problems and creatively approach the design.
What was one area of React you gained more clarity on during this assignment? Relationship and parent and child interaction (as well as child to parent to child/sibling)
Describe how you solved the problem of having lists of movies that look mostly the same but have different content If the movie has the same external_id as something already in the library the user cannot post it to the rental library. This logic was placed in the backend Create action for Movies controller.
Describe how you handled rentals with React Very convolutedly. The selection come from the Rental Library and the Customer List individual component for customer and movie. onClick of the button in the small components, the customer or movie component sends the customer or movie object to the parent which then sends it to be stored in the App component. When the checkout button is clicked the selected movies are submit as a post request to rentals to make a new Rental.
Describe a DOM event your application handled onClick for Adding to Library, triggers a callback function that posts a new movie to the Movie model in the backend
Did you use any functional stateless components? What for? Yes, I believe it is SelectButton that is used to render the button to select a customer, movie, or add a movie to library. Didn't use the functional stateless notation originally
Did you use any container components? What for? No, what might have been doesn't just have stateless functional components.
Do you have any recommendations on how we could improve this project for the next cohort? Not really, (though people might not like this, having more to do in the backend, it felt very much like working mostly a frontend rather than fullstack)

kcforsman and others added 30 commits June 18, 2018 15:37
…omers from our Rails api, and installed axios to package.json
…a click event to determine which component is displayed from CustomerList, RentalLibrary, and SearchBar, and began filling in the App component
…nents include MovieSearch and SearchBar with content but no functionality
…or implementing selecting a movie or customer from app lists
… on nested callback function to update the apps state for a selected customer from the onClick of the SelectionButton to the Customer to the Customer list to the App. the change in the App's state then updates the props that are sent to the Checkout component
…r to the rentalLibrary to select a movie. We now save both a movie and a customer to the App state which populates the Checkout Component with a name and a title
…d code, and fixed CustomerDetail Component from merge so that credit is an optional prop
kcforsman and others added 30 commits June 19, 2018 22:23
… api results and added render function to MovieSearch to render results components only after a search has been made
… ReactRouter and fixed issue for the RentalLibrary and CustomerList Components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants