Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ampers: Angela Poland #30

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

AngelaPoland
Copy link

Inspiration Board

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Explain the steps in creating a new Card from the form. User fills in the new cad form at the top of the page and presses "add card". Once pressed, a callback function for the Card is called from the Board component. The Board component makes an API request and updates the state of the cards then re-renders.
How did you learn how to use the API? Played around in Postman and console.logged the response after reading up on the documentation.
What function did you use to place the GET request from the API to get the list of cards? Why use that function? That would be the componentDidMount function. It is invoked before the page is re-rendered.
Explain the purpose of a Snapshot test. It converts the rendered html of the component into JSON, saves it in a snapshot file, and compares future runs of the test to that snapshot.
What purpose does Enzyme serve in testing a React app? Enzyme is how we test with the functions "shallow" or "mount".

@CheezItMan
Copy link

Inspiration Board

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Check
Comprehension questions Check
General
Card Component renders the data provided as props Check
Board Component takes a URL and renders the list of Cards and passes in callback functions Check
NewCardform Component is a controlled form and uses a callback function to return entered data to the parent component Check
API
GET request made in componentDidMount Check
DELETE request made in callback function Check
POST request made in callback function passed to NewCardForm component. Check
Snapshot testing Check
Styling Functional but effective
Overall Nice work you hit all the major learning goal Well done!

</div>
)
}

}

Board.propTypes = {

cards: PropTypes.array.isRequired,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm... this isn't being used anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants