Skip to content

Queues - Erica Case- Trek #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

EricaJCasePhD
Copy link

@EricaJCasePhD EricaJCasePhD commented May 30, 2017

TREK

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
What does it mean for code to be asynchronous? Code is executed simultaneously rather than sequentially. This means code could run before the elements it uses have loaded.
Describe a piece of your code that executes asynchronously. How did this affect the way you structured it? Most of the buttons are asynchronous; I had to switch from .click() to .on() for event delegation.
What kind of errors might the API give you? How did you choose to handle them? One error is that the API could say a trip doesn't exist. I handled that with a failure case that gave an alert message.
What is an Underscore template? Describe one template you used for this project. An underscore template is similar to a view - it determines the appearance and data that will be displayed.
Do you have any recommendations on how we could improve this project for the next cohort?

@droberts-sea
Copy link

TREK

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene yes
Comprehension questions yes
Functionality
Click a button to list trips yes
Click a trip to see trip details yes
Fill out a form to reserve a spot no - your code to add the reservation form almost works, I just had to change the jQuery selector for where to put it from $('vacations') to $('#vacations'). However, you do not have any code to handle form submission.
Errors are reported to the user no - you have some jQuery code to put an error message on the page, but it the element it targets doesn't exist so nothing appears
Styling, Foundation grid layout yes - great work here!
Under the Hood
Trip data is retrieved using jQuery AJAX yes
JavaScript is well-organized and easy to read yes
HTML is semantic yes
All dynamic content is rendered using Underscore templates yes
Overall

This is a good start. I appreciate the effort you put into styling, but I would appreciate it if next time you tackled the main learning objectives first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants