fix #35 Raise 404 ObjectNotFound when a single resource does not exist #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

dmitrymishanov merged 1 commit into AdCombo:master from samuelfirst:fix_raise_404_ObjectNotFound

Jun 9, 2021

Contributor

samuelfirst commented Jun 7, 2021

No description provided.

Contributor

dmitrymishanov commented Jun 9, 2021

Hi! @samuelfirst please cover your changes with a test case


          fix AdCombo#35 Raise 404 ObjectNotFound when a single resource does n…

e921239

…ot exist

samuelfirst force-pushed the fix_raise_404_ObjectNotFound branch from a62f99b to e921239 Compare

June 9, 2021 07:09

coveralls commented Jun 9, 2021

Pull Request Test Coverage Report for Build 920827834

5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.04%) to 82.885%

Totals
Change from base Build 905435998:	0.04%
Covered Lines:	1293
Relevant Lines:	1560

💛 - Coveralls

dmitrymishanov approved these changes

View reviewed changes

dmitrymishanov merged commit dfe00fb into AdCombo:master

Collaborator

mahenzon commented Jun 9, 2021

Thanks!

We need two more fixes to release 1.1.0:
https://github.com/AdCombo/flask-combo-jsonapi/milestone/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet