Repository navigation
fix(ui): dismissable multi-device note; drop synthetic category tag from search results - #1062
Conversation
…rom search results - Activity: the 'Browser and stopwatch data are only available when viewing a single device' note showed on every multi-device view. It is now a dismissable info alert; the dismissal persists in localStorage. - Search: every hit carried `$category: ["searched"]`, the synthetic category the query uses for filtering. Strip it from the results. Part of ActivityWatch#1058. Git-Session-Id: a40d
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1062 +/- ##
==========================================
+ Coverage 63.30% 63.35% +0.05%
==========================================
Files 52 53 +1
Lines 3608 3616 +8
Branches 892 887 -5
==========================================
+ Hits 2284 2291 +7
+ Misses 1309 1244 -65
- Partials 15 81 +66 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
Two of the "Minor" items from #1058.
localStorage(aw-multidevice-note-dismissed), same approach as the supporter nudge on Home. The logic lives insrc/util/multideviceNote.tsso it is unit-tested (Activity.vueitself does not load under jest).$category: ["searched"]tag — the search query categorizes every event into a syntheticsearchedcategory to filter on it, and that leaked into each result row. Results now drop$category.Not in this PR, with reasons
app_eventsismerge_events_by_keys(title_events, ["app"]), which keeps onlyapp, so the app row is classified from the app name alone. Rules match titles (GitHub,YouTube, …), and a browser's name matches none of them. Fixing it means picking a semantics: dominant category of the app's title events, or a per-app category fromcat_events. That's a design call, so I'd rather not guess it in a minor-items PR.Verification
jest test/unit/multideviceNote.test.js: 2 passedeslintclean on changed files,tsc --noEmitclean,vue-cli-service buildsucceeds (this is the check that the pug template compiles)