Repository navigation
UI color change. #412
Description
Activity
The color picker could be simplified by removing the row of colors not quite usable for a particular theme. Darker colors work bad on light theme, because the text is dark, and same for the dark theme - light text doesn't work on lighter colors. There is no need in giving options that work bad.
There is another way of looking on those colors: lighter colors on the light theme are normal colors with lowered transparency. Same for the darker colors on dark theme.
When switching themes, lighter colors should be changed to their darker versions with the same hue. Normal colors (the middle row on the palette) should remain the same. Colors defined by the user should be recalculated, while palette colors could just be swapped with their darker/lighter sibling.
Reacted by BrayoThe text color should vary depending on the color it is been displayed on. There won't be a single color that is good for all background colors so a function that determines the text color depending on the category color is better suited, imo
Looks good, I will check into incorporating it later.
are you working on it?
Hey, been a little swamped the last few weeks. I noticed that there's the issue of the text overflowing between the two backgrounds
Your code would work perfectly for the first category but for the second and the third, you would need to change text color twice depending on what the background is. Doable but more complex than necessary, a fix could be to make the categories all the same width. Not sure if that would be merged. Curious to hear your input :)
Also should you have the time, feel free to make a PR, will be much better to discuss it with actual code.
Assuming we have a light category color such as below.
The correct text color would be something quite dark for good contrast with that color. But once that text overflows the category color, the legibility would be poor, black on black background or if having a dark category color a white text color on white background. I agree for ensuring the legibility and contrast your code works. But there's a background color legibility case, they have to be fixed/merged together.
The reason that the current code defaults to white text color is actually because of the legibility on the dark background once text overflows. I'll experiment with code for generating optimal colors for both backgrounds and update this later today.
We can simply pick default colors from the LAB color plane where
lightness = 50. They look good behind both black and white font. By the way, the default colors are way too bright.Here is a LAB color picker.
- added a commit that references this issue
on Oct 6, 2026
We are not able to read text due the background color.
I have made few changes .
Should I do a PR for the same