Skip to content

WIP: Query2 test make variables get consumed - #122

Draft
johan-bjareholt wants to merge 1 commit into
masterfrom
dev/query2-consume-vars
Draft

johan-bjareholt wants to merge 1 commit into
masterfrom
dev/query2-consume-vars

Conversation

@johan-bjareholt

@johan-bjareholt johan-bjareholt commented May 31, 2020 •

Copy link
Copy Markdown
Member

ToDo:

  • & should mean reference, right now it means clone to get tests working
  • Make "read-only reference" a part of the language

@johan-bjareholt
johan-bjareholt marked this pull request as draft May 31, 2020 06:39
Previously they were cloned on each reference
@johan-bjareholt
johan-bjareholt force-pushed the dev/query2-consume-vars branch from 76f81a5 to c423321 Compare May 31, 2020 06:40
@codecov

codecov Bot commented May 31, 2020 •

Copy link
Copy Markdown

Codecov Report

Merging #122 into master will decrease coverage by 0.06%.
The diff coverage is 81.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
- Coverage   65.89%   65.82%   -0.07%     
==========================================
  Files          52       52              
  Lines        5864     5870       +6     
==========================================
  Hits         3864     3864              
- Misses       2000     2006       +6     
Impacted Files Coverage Δ
aw-query/src/ast.rs 0.00% <0.00%> (ø)
aw-query/tests/query.rs 90.02% <ø> (ø)
aw-query/src/interpret.rs 81.13% <83.33%> (-0.16%) ⬇️
aw-query/src/lexer.rs 85.71% <100.00%> (+0.20%) ⬆️
aw-query/src/parser.rs 30.53% <100.00%> (-0.09%) ⬇️
aw-query/src/functions.rs 88.85% <0.00%> (-0.61%) ⬇️
aw-query/src/datatype.rs 78.64% <0.00%> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 132370b...c423321. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant