Repository navigation
Privacy Filters feature isn't working #659
Description
Activity
The rules were saving. They were never loaded into the engine that actually filters inserts.
DatastoreWorkerstarts with an emptyPrivacyFilterEngine. Insert/heartbeat already callfilter_event, andRefreshPrivacyFilterknows how to reloadsettings.privacy_filters— but nothing called refresh after save, and startup never read the persisted key. So drop/redact rules looked broken on stock beta and on a self-built server.Fix: #662 — reload on save/delete of that key, and load it at worker startup. A datastore test now saves a drop rule, inserts a matching event, and asserts it is not stored (no explicit refresh call).
Once that merges, a saved drop rule should actually drop. I'll close this only after that lands, not just because the PR exists.
Reacted by akirad3d4It seems to me that the
redactaction uses a simple replacement without the ability to extract information from the pattern and apply it during the replacement. It would be great if it worked the same way as the filters in awatcher.Yes — redact was whole-field only. Capture-group replacement is in #665, with the same
$1/$namesemantics as awatcher.Example: pattern
● (.*)and replacement$1turns"● file.rs - Visual Studio Code"into"file.rs - Visual Studio Code". A rule with no capturing groups still replaces the whole field, so existingREDACTEDrules stay the same.The original "filters never apply" bug is still #662; I'll close this issue after that merges, not because the capture-group PR exists.
Reacted by akirad3d4- added a commit that references this issue
on Aug 31, 2026 #662 is still the merge that lands this on master. I don't have merge access on this repo, so it waits on a maintainer.
CI is green, the PR is mergeable, Greptile is 5/5, and your week on the branch is the live confirmation. I'll close this issue after that merge.
- added a commit that references this issue
on Sep 11, 2026
I've been using the beta versions (not research) for a while now, but I still haven't been able to get the privacy filters to work. The redact and drop actions don't work, so events that should match the filters are saved unchanged, no matter what. I tried building a server on my own, but ran into the same problem.