Repository navigation
DELETE endpoint to delete event(s) #60
Description
My suggested API:
- Remove
DELETE <bucketname>/events/<id>endpoint - Add
POST <bucketname>/events/delete/by_ids - Add
GET <bucketname>/events/delete/by_period?start=X&end=X
Reasons why the old delete API is bad and should be replaced completely:
- The new "by_ids" endpoint makes it possible to remove multiple specific events in one go while the old API could only delete one event at a time.
- The old DELETE endpoint is also broken because both
/events/<id>and/events/countare in the same namespace
Things which need to be considered:
- Vacuuming the database
Resources:
- Discussion with @leoschwarz in aw-server-python PR Expose replace event endpoint aw-server#57
Activity
[-]DELETE endpoint to delete event[/-][+]DELETE endpoint to delete event(s)[/+]ErikBjare commentedon Aug 28, 2019
We should keep in mind that we might want to use the pragma
secure_deleteor run aVACUUMto ensure secure deletion of data.johan-bjareholt commentedon Aug 28, 2019
Maybe run VACUUM when aw-server is starting up?
Seems like a sane time to do it.
johan-bjareholt commentedon Aug 28, 2019
secure_delete=FAST seems like the best approach for us I believe.
ErikBjare commentedon Aug 28, 2019
If the operation is somewhat costly then I'd rather not as that could slow down the startup time of the Android app (less of a concern on desktop, where the user is unlikely to use ActivityWatch the moment it's started).
johan-bjareholt commentedon Aug 28, 2019
Hm, I guess that's true.
A solution would be to have it as both an API endpoint to manually start a VACUUM as well as maybe store the last time a VACUUM was performed and do it once every X months.
johan-bjareholt commentedon Jan 14, 2020
So the delete endpoint for a single event just as for aw-server-python is now implemented but there is no VACUUM for now.
Maybe we should have a new issue for VACUUM?
johan-bjareholt commentedon Apr 5, 2020
Updated the issue body
feat(server): bulk event delete endpoint POST /buckets/<id>/events/de…