Repository navigation
Conversation
|
7 of 20 tasks
BackgroundService.onCreate built RustInterface on the main thread, which loads libaw_server.so and runs the JNI initialize: the startup hang ActivityWatch#262 removed from the watchers. Construct it with OffThreadInit and await it in the IO coroutines that already use it. A native-library failure is now logged instead of crashing the service.
0xbrayo
force-pushed
the
perf/background-service-off-thread-init
branch
from
October 8, 2026 19:37
bf24a6c to
f0a8819
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #333.
BackgroundService.onCreateconstructedRustInterfaceon the main thread. Construction runsSystem.loadLibrary("aw_server")plus the JNIinitialize/setDataDir, which the code's own comment notes "can take several seconds on slow/no-KVM emulators". #262 moved exactly this off the main thread for the watchers, MainActivity and the alarm receiver; the service was the remaining caller.Change
rustInterfaceis now anOffThreadInit<RustInterface>started inonCreate, after foreground promotion as before.await()it there.sanitizedMigrationLock. Construction doesn't open the database, so it doesn't need to be ordered against the hostname rewrite.onCreate.Testing
./gradlew :mobile:testStandardDebugUnitTestpasses, includingBackgroundServicePolicyTestandOffThreadInitTest.