Repository navigation
Conversation
|
7 of 20 tasks
The flag is written on the main thread when the server exits and polled in a loop by the hostname-rewrite thread, which without @volatile is not guaranteed to ever see the change.
0xbrayo
force-pushed
the
fix/server-started-volatile
branch
from
October 8, 2026 19:37
f77c6b5 to
9e5d9e3
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #333.
RustInterface.serverStartedis shared across threads:true,Handlersets it tofalsewhen the server exits,BackgroundService'ssanitized-hostname-rewritethread polls it in awhile (RustInterface.serverStarted) Thread.sleep(...)loop.Without
@Volatile, the Java memory model doesn't guarantee that the polling thread ever sees the main thread's write, so the queued hostname rewrite could wait forever.Change
@Volatile.Testing
./gradlew :mobile:testStandardDebugUnitTestpasses.