Repository navigation
Conversation
aw-server-rust emits 'Zero peers in a configured sync dir…' (capital Z) but the push-only filter checked 'zero peers' (lowercase), so the warning was never suppressed. Use it.lowercase() to make the match case-insensitive. Fixes: ActivityWatch#321 Git-Session-Id: f63a
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| // (aw-server-rust#687) — not meaningful on Android where pull is a no-op by | ||
| // construction (SAF mirror is outbound-only until sync v2). | ||
| val warnings = if (isPushOnlyDevice) status.warnings.filter { "zero peers" !in it } else status.warnings | ||
| val warnings = if (isPushOnlyDevice) status.warnings.filter { "zero peers" !in it.lowercase() } else status.warnings |
There was a problem hiding this comment.
Both existing warning tests use lowercase "zero peers", so they still pass with the broken, case-sensitive filter. Update the suppression test to use "Zero peers" or add a mixed-case case that fails without this change. That would catch a future change that brings back the misleading warning.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Fixed in ae02c9a: updated the primary suppression test to use "Zero peers" (capital Z, as emitted by aw-server-rust) and added a lowercase variant. The original tests were passing with the broken case-sensitive filter — now the capital-Z case would have caught the bug.
Both suppression tests used lowercase "zero peers" — they passed with the old broken case-sensitive filter, so they provided no coverage for the actual bug. aw-server-rust emits "Zero peers" (capital Z); update the primary suppression test to use that form and add a lowercase variant to verify both cases are handled by the case-insensitive filter. Git-Session-Id: 10abe743-3a89-594d-98d8-b385b7ff3722
|
@greptileai review |
|
The E2E failure ( Attempted a CI rerun but don't have admin rights for that. A maintainer rerun should confirm this is a flaky emulator test, not a regression from this change. |
…ivityWatch#322) Six light-mode screenshots of v0.14.2 with demo data (Pixel-class 1080x2400): activity day, day categories, 30 days, week, category sunburst, timeline.
Git-Session-Id: 3a67ecec-28dc-57d8-b918-bdc6f9f45f68
…tch#326) * fix(ui): let SyncSettingsActivity follow system dark mode applySafeWindowInsets() always called applySystemBarAppearance(darkContent=false), hardcoding white background for all native screens even in dark mode. This made system bar icons and window background stay light regardless of the device theme, causing white-on-white text in SyncSettingsActivity when dark mode is on. Add a followNightMode parameter (default false — preserves existing behaviour for MainActivity which drives appearance from the embedded web UI). SyncSettingsActivity passes followNightMode=true so its DayNight theme attributes resolve to the correct colours automatically. Fixes item 5 in ActivityWatch#321. Git-Session-Id: 766d * docs(colors): update night-mode guidance — SyncSettings now follows DayNight Git-Session-Id: 766d
…ctivityWatch#327) With gesture navigation a back-swipe finished MainActivity even when the embedded web UI had pages to go back to. Back now closes the drawer first, then goes back in the WebView, and only finishes when there is no history left. Part of ActivityWatch#321 (item 6). Git-Session-Id: f4b5
|
The CI failure is in No code change needed; can merge once a clean E2E run lands or the maintainer is comfortable with the known flake. |
…lter' into fix/zero-peers-case-insensitive-filter Git-Session-Id: d056
|
The E2E failure is in |
|
CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
2 participants
Summary
The push-only device filter at
SyncSettingsActivity.kt:103was checking"zero peers" !in it(lowercase), but aw-server-rust emits:The capital Z means the filter never matched, so the warning was always shown
on push-only Android devices even though it's meaningless there (SAF mirror is
outbound-only until sync v2).
Fix: use
it.lowercase()for a case-insensitive containment check.Root cause
Found during investigation of #321 (Android double-start / data-loss bugs).
aw-sync/src/util.rs:1102hasZero peers(capital Z); the Android filterhad
"zero peers"(lowercase) — one-character case mismatch.Test plan
warning no longer appears
Ref: #321