Skip to content

fix(android): use light-only theme for Auth/Sync/Onboarding screens #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ErikBjare merged 1 commit into from
Oct 10, 2026
+14 −1
Merged

fix(android): use light-only theme for Auth/Sync/Onboarding screens #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion mobile/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,19 +48,21 @@
android:name=".OnboardingActivity"
android:screenOrientation="portrait"
android:configChanges="orientation"
android:theme="@style/AppTheme.NoActionBar"
android:theme="@style/AppTheme.LightOnly"
android:exported="true" />

<activity
android:name=".AuthSettingsActivity"
android:screenOrientation="portrait"
android:configChanges="orientation"
android:theme="@style/AppTheme.LightOnly"
android:exported="false"/>

<activity
android:name=".SyncSettingsActivity"
android:screenOrientation="portrait"
android:configChanges="orientation"
android:theme="@style/AppTheme.LightOnly"
android:exported="false"/>

<receiver
Expand Down
11 changes: 11 additions & 0 deletions mobile/src/main/res/values/styles.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,17 @@
<item name="windowActionBar">false</item>
<item name="windowNoTitle">true</item>
</style>
<!-- Light-only theme for native screens that pin their background to
chrome_light via applySafeWindowInsets(). DayNight would resolve
text colour attributes (textColorSecondary, textAppearanceListItem …)
to white in night mode while the background stays white → unreadable.
Theme.AppCompat.Light.NoActionBar already disables the window action
bar, so no extra item overrides are needed. -->
<style name="AppTheme.LightOnly" parent="Theme.AppCompat.Light.NoActionBar">
Comment thread
TimeToBuildBob marked this conversation as resolved.
<item name="colorPrimary">@color/colorPrimary</item>
<item name="colorPrimaryDark">@color/colorPrimaryDark</item>
<item name="colorAccent">@color/colorAccent</item>
</style>
<style name="AppTheme.AppBarOverlay" parent="ThemeOverlay.AppCompat.Light"/>
<style name="AppTheme.PopupOverlay" parent="ThemeOverlay.AppCompat.Light"/>

Expand Down
Loading