Repository navigation
ci: PRs build one leg per OS family; Intel/arm/research/glibc-floor variants on master and tags - #1517
ci: PRs build one leg per OS family; Intel/arm/research/glibc-floor variants on master and tags#1517ErikBjare wants to merge 3 commits into
Conversation
… label to override)
|
@greptileai review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
…loor) on master/tags
|
@greptileai review |
🤖 AI code reviewThis PR modifies the release workflow to reduce CI load on PRs by building only one leg per OS family (skipping Intel macOS, ARM, and variant rows) unless the Safe to merge — no P0/P1 findingsConfidence 5/5 ✅ No findings. The diff looks correct to me on this pass. Files changed (1) — the diff as I read it
Reviewed Maintainer commands
|
PR runs of the release workflow built 14 artifact jobs, including the slowest and scarcest legs (Intel macOS averaged 35 min vs 17 for macos-latest, about 2/3 of PR macOS minutes). Most of these legs give little PR-specific signal; platform-variant breakage is rare and is caught on master and at tag time, before anything ships.
PRs (without the
ci:fulllabel) now build one leg per OS family:--check) and run the patcher tests on every PRMaster, tags, dispatch and cron are unchanged. The full matrix still runs there: macos-15-intel (Qt + Tauri), ubuntu-24.04-arm, windows-11-arm, the research rows, and manylinux_2_28.
How:
oslists arefromJSONexpressions;researchis false on plain PRs, so it merges into the ubuntu row;includelist is afromJSONexpression, empty on plain PRs, otherwise the same two rows as before;if:skips plain PRs.releasestill requires manylinux and all builds on tags.Full matrix on a PR: add the
ci:fulllabel, then push. There's nolabeledtrigger, because any label (Dependabot, Bob, triage) would re-run the whole workflow. Don't use workflow_dispatch for this: preflight can then cut a dev prerelease tag.Verified: this PR's own run (38067780593) created exactly the 6 builds + smoke tests above, with manylinux skipped. The non-PR path (the
format()-built include list on push/tag) is only exercised by a master push. Merge after tagging v0.14.1, and check the master run's job list then. Before this PR, master runs created 14 build jobs plus manylinux, and the next master run should create the same.