Sharrow fix all #15
Merged
Sharrow fix all #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i-am-sijia
requested changes
May 21, 2024
Member
i-am-sijia
left a comment
i-am-sijia
left a comment
There was a problem hiding this comment.
You missed Trip Destination choice. Sharrow is still turned off, at least in its settings. I realized this after looking at the latest benchmarking result.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes all necessary changes to get sharrow working on this model from head to toe.
landuse_orig_*variables in accessibility.fillnatonan_to_numfor sharrow compatability.fastmathin components that haveNaNvalues that must be processed.omx_ignore_patternssetting to skim loading redundant bike skims.These changes also require ActivitySim/activitysim#867