Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(MQServiceTaskIT): add should replay running service task integration test #887

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

igdianov
Copy link
Contributor

This PR adds integration test to ensure users can trigger replay for service tasks in started state in case when the integration result message has not been received by process runtime to complete the execution.

@igdianov igdianov self-assigned this Oct 28, 2022
@igdianov igdianov enabled auto-merge (squash) October 28, 2022 03:43
Comment on lines +156 to +158
assertThat(runtimeService.createProcessInstanceQuery()
.processInstanceId(procInst.getProcessInstanceId())
.list()).isEmpty();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you, please, also add an assertion to check that no integration context related to this process instance was left behind?

@igdianov igdianov force-pushed the dev-igdianov-replay-started-service-task-test branch from 1226cae to 073f93e Compare November 9, 2022 21:44
@atchertchian
Copy link
Contributor

If this PR shows conflicts, here are instructions to help rebasing this work branch after reformat at 814a919:

git rebase c845f509770e38aa9663a97cb2f9bcd3e5d39e28
git rebase --strategy-option=theirs --exec 'pre-commit run --from-ref HEAD~ --to-ref HEAD' 814a9190ff60af86086e8d111660146569ef6e19
git rebase develop

The last rebase should be omitted if another reformat has happened (similar instructions should be followed for rebase over next reformat).

See more details at Activiti/Activiti#4277.

@CLAassistant
Copy link

CLAassistant commented Aug 23, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants