Thank you for this opportunity! #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick note if I had longer I would have added logging and made a more robust way to iterate through the xml tree. I would also move the more robust iterator to its own file and function so that it could be reused for other projects. There also appears to be an issue with people not filling out the bedroom and bathrooms field. Parsing the description appears to have correct numbers. If I had more time I would use the data in the description to create a better data set by parsing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick note if I had longer I would have added logging and made a more
robust way to iterate through the xml tree.
I would also move the more robust iterator to its own file and function
so that it could be reused for other projects.
There also appears to be an issue with people not filling out the
bedroom and bathrooms field.
Parsing the description appears to have correct numbers.
If I had more time I would use the data in the description to create a
better data set by parsing it.