Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify trove classifier list #111

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Simplify trove classifier list #111

merged 1 commit into from
Sep 12, 2018

Conversation

jdufresne
Copy link
Contributor

Easier to simply define a list of strings instead of processing a big string with split() & strip().

@McSinyx
Copy link

McSinyx commented Aug 28, 2018

Although the original setup.py is already inconsistent, I still think single quote would look better. Just my personal preference. Until there is any response from the @ActiveState team, IMHO setup.py is not so important for blaming that you cannot simply switch to use one.

Easier to simply define a list of strings instead of processing a big
string with split() & strip().
@jdufresne
Copy link
Contributor Author

jdufresne commented Aug 28, 2018

I'm fine either way. Updated to use single quotes.

@zoofood zoofood merged commit 422d7e4 into ActiveState:master Sep 12, 2018
@jdufresne jdufresne deleted the simplify-trove branch September 17, 2018 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants