Unlock mail gem version for newer ruby versions #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balvig
force-pushed
the
jb/unlock-mail-gem-version
branch
from
c0b40b3 to
655aea6
Compare
balvig
changed the title
balvig
force-pushed
the
jb/unlock-mail-gem-version
branch
3 times, most recently
from
2f2d6b2 to
23b214f
Compare
balvig
force-pushed
the
jb/unlock-mail-gem-version
branch
from
23b214f to
308a4b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Alternate workaround to #135 and #143.
Why
While there still seems to be an issue with
add_mail"clearing"body, instead of locking the gem for all ruby version and making it difficult to test newer ones, we can limit the version restrictions to legacy version and use this workaround of flipping the order for Ruby 2.x.