This repository was archived by the owner on Mar 27, 2023. It is now read-only.
Add URI encoding for path info #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I did this because sometimes the request path will be encoded. Since HTTP router unencodes the path, it loses the ability to correctly calculate the path info by performing math on the path length. This encodes the path info since it is used for correctly assigning the script name.
Author
|
@cyphactor check it out |
|
👍 |
RyanHedges
added a commit
that referenced
this pull request
Feb 9, 2016
Add URI encoding for path info
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this because sometimes the request path will be encoded. Since HTTP
router unencodes the path, it loses the ability to correctly calculate the
path info by performing math on the path length. This encodes the path info
since it is used for correctly assigning the script name.