[FIX] 온보딩 프로세스 노출 로직 수정 (#270) #271
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from: Global > UIComponents to: Presentation > Login
from: 시작 버튼 클릭 -> to: TutorialVC didAppear
Closed
1 task
from: viewWillAppear -> to: viewDidAppear
cirtuare
approved these changes
Sep 22, 2025
Contributor
cirtuare
left a comment
cirtuare
left a comment
There was a problem hiding this comment.
최고 !!! 알림 확인하고 그대로 까먹어서 늦었습니다... ㅠㅠㅠ 죄송해요
그리고 바로 맵뷰로 넘어가는 거 없어졌다니...너무 좋다
Comment on lines
143
to
151
| // NOTE: 로그인O && 지역인증X -> 지역인증VC | ||
| else if !hasSeenLocalVerificationOnboarding { | ||
| NavigationUtils.navigateToOnboardingLocalVerification() | ||
| } | ||
|
|
||
| // NOTE: 로그인O && 지역인증O && 취향탐색X -> 취향탐색VC | ||
| else if !hasSeenPreferenceOnboarding { | ||
| NavigationUtils.naviateToLoginPreference() | ||
| } |
Contributor
There was a problem hiding this comment.
이거 navigateToLoginPreference를 navigateToOnboardingPreference로 바꾸는 건 어떨까요?? 좀 더 통일성 있을 것 같아서 제안드려봅니당
Collaborator
Author
There was a problem hiding this comment.
좋아요~ flowType도 같이 login -> onboarding으로 수정했어요~
enum PreferenceFlowType {
case login onboarding, setting
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐿️ Pull Requests
🪵 작업 브랜치
🥔 작업 내용
앱 실행 후, <서비스 온보딩>, <지역 인증>, <취향 탐색>을 노출하는 로직에 대한 수정입니다.
변경1. 온보딩 프로세스 순서 변경
변경2. 온보딩은 1회만 노출
ex) 서비스 온보딩 중 앱 강제종료 시: 이후 다시 앱 켜면 <지역 인증> 온보딩부터 시작
hasSeenTutorial,hasSeenLocalVerification,hasSeenPreferenceUserDefaults 키를 true로 set변경3. 딥링크 진입 후 로직 수정
🚨 참고 사항
기존에 사용하던
hasPreference는 앱 내에서 사용할 일이 없어졌지만,키를 삭제하진 않았습니다
취향탐색에 대한 네이밍을 수정했습니다.
Onboarding -> Preference
마지막으로,
LocalVerificationVC에서 자동으로 LocalMapVC로 넘어가는 문제가 해결된 것 같습니다! Yayyyy 🤗 (이유는 idk🤷♀️)
📸 영상
(지역인증 건너뛰기, 취향탐색 강제종료)
💥 To be sure
🌰 Resolve issue