[FEAT] 장소 업로드 - 항목 선택 버튼 컴포넌트화, 사진업로드 외 나머지 페이지 구현 (#230) #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'develop' into feature/#230
glassView, glassBorder 모두 설정된 경우 대응
1 task
cirtuare
approved these changes
Jul 25, 2025
Contributor
cirtuare
left a comment
cirtuare
left a comment
There was a problem hiding this comment.
💗 역시 베이스 파일 잘 만들어두니까 깔꼼하네용 최고!!!
그냥 추가적으로 제안 드려보자면... 개인적으로 버튼 스택뷰 + 버튼 제목 enum을 만들어서 쓰면 좀 더 재사용이 가능하지 않을까 생각해봤습니당
Comment on lines
+28
to
+49
| extension SpotUploadType { | ||
|
|
||
| // MARK: - Restaurant | ||
|
|
||
| enum RestaurantOptionType: CaseIterable { | ||
|
|
||
| case korean, chinese, japanese, western, asian, fusion, koreanStreet, buffet, bar, others | ||
|
|
||
| var text: String { | ||
| switch self { | ||
| case .korean: return "한식" | ||
| case .chinese: return "중식" | ||
| case .japanese: return "일식" | ||
| case .western: return "양식" | ||
| case .asian: return "아시안" | ||
| case .fusion: return "퓨전" | ||
| case .koreanStreet: return "분식" | ||
| case .buffet: return "뷔페" | ||
| case .bar: return "술/bar" | ||
| case .others: return "기타" | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
🐿️
SpotUploadType 중 SpotFilterType과 겹치는 부분들은 따로 빼는 건 어떨지 제안드려봅니당
Collaborator
Author
There was a problem hiding this comment.
음... 혹시 CommonRestaurantOptionType 등으로 공통 case를 관리하자는 제안이실까요?
그렇게 될 경우 allCases 등을 사용하기 불편하다는 단점이 있을 것 같습니다...!
혹시 제가 잘못 이해했다면 코드 예시를 제시해주실 수 있을까요?
Comment on lines
+82
to
+83
|
|
||
| // MARK: - @objc functions |
Collaborator
Author
|
Merge branch 'develop' into feature/#230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐿️ Pull Requests
🪵 작업 브랜치
🥔 작업 내용
🚨 참고 사항
(배경이 검정색이라서 크게 문제되지 않으며, 디자이너와도 상의 완료했습니다!)
📸 스크린샷
ScreenRecording_07-26-2025.02-34-41_1.mov
💥 To be sure
🌰 Resolve issue