-
Notifications
You must be signed in to change notification settings - Fork 1
[FEAT] 자전거 길찾기 네이버맵 연동, 기타 오류 해결 (#195) #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces bicycle route navigation integration with Naver Map and resolves several UI and data errors in the SpotList views. Key changes include ad index adjustments in the collection view, improved handling of skeleton views in cells, and updated map redirection logic with transport mode support.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| SpotListViewController.swift | Adjusts item count to account for ads and refines cell selection logic. |
| SpotListCollectionViewCell.swift | Disables user interactions on skeleton views and ensures they are hidden appropriately. |
| NoMatchingSpotListCollectionViewCell.swift | Removes skeleton view setup to reflect the absence of matching spots. |
| TransportModeType.swift | Adds a computed property for Naver Map key retrieval. |
| SpotDetailViewModel.swift | Adds an optional transportMode property for map redirection. |
| SpotDetailViewController.swift | Updates initializer and redirection actions to pass transport mode. |
| MapRedirectManager.swift, NaverMapService.swift, AppleMapService.swift, MapServiceProtocol.swift | Modify map redirection API to include transport mode as a parameter. |
Comments suppressed due to low confidence (1)
ACON-iOS/ACON-iOS/Presentation/SpotList/View/SpotListViewController.swift:616
- [nitpick] The variable name 'adAboveCount' could be more descriptive. Consider renaming it to 'numAdsBeforeCell' for improved clarity.
+ let adAboveCount = indexPath.item / 5
| to: MapRedirectModel(name: spot.name, latitude: spot.latitude, longitude: spot.longitude), | ||
| using: .apple) | ||
| mapType: .apple, | ||
| transportMode: .walking) |
Copilot
AI
Jun 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Apple map navigation in SpotDetailViewController uses transportMode .walking, which is inconsistent with the bicycle route intent and the behavior in SpotListViewController (which uses .biking). Consider updating this to .biking for consistency.
🐿️ Pull Requests
🪵 작업 브랜치
🥔 작업 내용
📸 스크린샷
2025-06-14.7.46.54-1.mov
💥 To be sure
🌰 Resolve issue