Skip to content

Conversation

@yurim830
Copy link
Collaborator

@yurim830 yurim830 commented Jun 14, 2025

🐿️ Pull Requests

🪵 작업 브랜치

🥔 작업 내용

  • 자전거 길 찾기 버튼 클릭 시, 네이버맵 자전거 경로 찾기로 이동되도록 구현
    • 북마크/딥링크 유저를 위한 대중교통 모드 추가
  • SpotList CollectionView 오류 해결
    • SpotListCollectionViewCell에서 삽입된 skeletonView가 길찾기 버튼의 인터랙션을 막는 이슈 해결
    • 광고가 skeleton 중일 때 터치 시 DetailVC로 넘어가는 문제 해결
    • 광고가 삽입되면서 해당 인덱스의 Datasource가 누락되는 문제 해결

📸 스크린샷

2025-06-14.7.46.54-1.mov

💥 To be sure

  • 모든 뷰가 잘 실행되는지 다시 한 번 체크해주세요 !

🌰 Resolve issue

@yurim830 yurim830 added this to the Sprint - 3 milestone Jun 14, 2025
@yurim830 yurim830 requested review from cirtuare and Copilot June 14, 2025 11:09
@yurim830 yurim830 self-assigned this Jun 14, 2025
@yurim830 yurim830 added ❤️‍🩹 bug 버그수정 🌀 feature 새로운 기능 개발 🥑 유림 유림 labels Jun 14, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces bicycle route navigation integration with Naver Map and resolves several UI and data errors in the SpotList views. Key changes include ad index adjustments in the collection view, improved handling of skeleton views in cells, and updated map redirection logic with transport mode support.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
SpotListViewController.swift Adjusts item count to account for ads and refines cell selection logic.
SpotListCollectionViewCell.swift Disables user interactions on skeleton views and ensures they are hidden appropriately.
NoMatchingSpotListCollectionViewCell.swift Removes skeleton view setup to reflect the absence of matching spots.
TransportModeType.swift Adds a computed property for Naver Map key retrieval.
SpotDetailViewModel.swift Adds an optional transportMode property for map redirection.
SpotDetailViewController.swift Updates initializer and redirection actions to pass transport mode.
MapRedirectManager.swift, NaverMapService.swift, AppleMapService.swift, MapServiceProtocol.swift Modify map redirection API to include transport mode as a parameter.
Comments suppressed due to low confidence (1)

ACON-iOS/ACON-iOS/Presentation/SpotList/View/SpotListViewController.swift:616

  • [nitpick] The variable name 'adAboveCount' could be more descriptive. Consider renaming it to 'numAdsBeforeCell' for improved clarity.
+        let adAboveCount = indexPath.item / 5

to: MapRedirectModel(name: spot.name, latitude: spot.latitude, longitude: spot.longitude),
using: .apple)
mapType: .apple,
transportMode: .walking)
Copy link

Copilot AI Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Apple map navigation in SpotDetailViewController uses transportMode .walking, which is inconsistent with the bicycle route intent and the behavior in SpotListViewController (which uses .biking). Consider updating this to .biking for consistency.

Copilot uses AI. Check for mistakes.
@yurim830 yurim830 merged commit 9e96aab into develop Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

❤️‍🩹 bug 버그수정 🌀 feature 새로운 기능 개발 🥑 유림 유림

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] 자전거 길찾기 네이버맵 연동, 기타 오류 해결

3 participants