[FEAT] 홈 - 장소 이미지 색상 추출 및 그림자 추가 (#158) #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirtuare
approved these changes
Jun 5, 2025
Contributor
cirtuare
left a comment
cirtuare
left a comment
There was a problem hiding this comment.
😽🍀 복잡하다 복잡해.. 고생했숨당 ~~~
Comment on lines
18
to
44
| switch self { | ||
| case .buttonGlassDefault, .buttonGlassPressed, .buttonGlassSelected, .buttonGlassDisabled, .toastGlass, .gradientGlass, .noImageErrorGlass: | ||
| return 0.2 | ||
| case .bottomSheetGlass, .alertGlass, .actionSheetGlass, .needLoginErrorGlass: | ||
| case .alertGlass, .actionSheetGlass, .needLoginErrorGlass: | ||
| return 0.4 | ||
| case .bottomSheetGlass: | ||
| return 0.6 | ||
| case .backgroundGlass: | ||
| return 1 | ||
| } | ||
| } | ||
|
|
||
| var blurEffectStyle: UIBlurEffect.Style { | ||
| switch self { | ||
| case .buttonGlassDisabled: | ||
| return .systemUltraThinMaterialLight | ||
| case .buttonGlassDefault, .actionSheetGlass, .noImageErrorGlass: | ||
| return .systemThinMaterialLight | ||
| case .buttonGlassPressed: | ||
| return .systemThickMaterialLight | ||
| case .buttonGlassSelected: | ||
| return .systemMaterialLight | ||
| case .buttonGlassDisabled: | ||
| return .systemUltraThinMaterialLight | ||
| case .toastGlass, .needLoginErrorGlass, .alertGlass: | ||
| return .systemThinMaterialDark | ||
| case .buttonGlassPressed: | ||
| return .systemThickMaterialLight | ||
| case .gradientGlass: | ||
| return .systemUltraThinMaterialDark | ||
| case .backgroundGlass, .bottomSheetGlass: | ||
| case .toastGlass, .needLoginErrorGlass, .alertGlass, .backgroundGlass, .bottomSheetGlass: | ||
| return .systemThinMaterialDark | ||
| } |
Contributor
There was a problem hiding this comment.
🐿️
전부 디자인이랑 합의된 사항들 맞을까요!!
Collaborator
Author
There was a problem hiding this comment.
네 맞습니다! 특별히 변경한 건 없고,
blurIntensity 부분에서 bottomSheetGlass만 0.4 -> 0.6으로 변경했습니다.
blurEffectStyle 부분은 light -> dark, thin -> think 순으로 정렬만 했어요!
Merge branch 'develop' into feature/#158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐿️ Pull Requests
🪵 작업 브랜치
🥔 작업 내용
🚨 참고 사항
bgImage는 cornerRadius 때문에
clipsToBounds = true여야 하기 때문에 여기에 그림자를 넣으면 그림자가 clip되는 문제가 있었습니다. 이에 shadowView를 별도로 분리했습니다.📸 스크린샷
💥 To be sure
🌰 Resolve issue