[FEAT] 홈 - 장소 없는 경우 UI(대신 여기는 어때요, 다음엔 추천해드릴게요), 서비스불가지역 UI 구현 (#156) #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirtuare
approved these changes
May 31, 2025
| override func setLayout() { | ||
| super.setLayout() | ||
|
|
||
| let edge = ScreenUtils.widthRatio * 16 |
Contributor
There was a problem hiding this comment.
🐿️
이거 제가 저번에 SheetUtils에 만들어 뒀습니당 ! 참고해주세요
Comment on lines
56
to
58
| $0.height.equalToSuperview() | ||
| $0.leading.equalToSuperview() | ||
| $0.centerY.equalToSuperview() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐿️ Pull Requests
🪵 작업 브랜치
🥔 작업 내용
메모리 절약을 위해 컬렉션뷰를 하나만 사용하고,
데이터에 따라 Layout과 Cell, Header를 갈아끼우는 방식으로 구현했습니다.
코드 중복을 최소화하기위해 SpotListCellConfigurable 프로토콜을 구현했습니다.
🚨 참고 사항
.bike인 상태에서 tag가 있을 때 아래처럼 레이아웃이 애매한 문제가 있는데, 이건 디자인측에 문의드린 상태입니다.
-> 수정 완료
TempErrorView 사용 뷰는 다른 브랜치에서 수정 후 삭제하겠습니다
📸 스크린샷
💥 To be sure
🌰 Resolve issue