[FEAT] 장소 상세 - 더보기 바텀시트 구현, 신고하기 웹뷰 연결 (#143) #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurim830
changed the title
cirtuare
approved these changes
May 17, 2025
Contributor
cirtuare
left a comment
cirtuare
left a comment
There was a problem hiding this comment.
min 적용한 거 좋네요 ~~ 고생하셨습니당 💗
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐿️ Pull Requests
🪵 작업 브랜치
🥔 작업 내용
핸들 세팅 메소드를 View를 분리하지 않은 VC에서도 쉽게 사용 가능하도록 BaseView에서 View extension으로 옮겼습니다.
🚨 참고 사항
지금은 더보기에 신고하기 하나만 있어서 단순 버튼으로 구현했습니다. 만약 다른 옵션이 더 추가될 경우, TableView로 수정하겠습니다.
비율 적용을 안 하면 SE에서, 비율 적용을 하면 16Pro에서 사이드 버튼 간 간격이 너무 떨어져있는 느낌이 들었습니다. 이에 min 메소드를 이용해 더 작은 패딩이 적용되도록 했습니다. 혹시 비교 사진 필요하면 말씀주세요!
📸 스크린샷
💥 To be sure
🌰 Resolve issue