[FEAT] 2.0 스플래시 / 로그인 UI (#138) #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurim830
approved these changes
May 14, 2025
Collaborator
yurim830
left a comment
yurim830
left a comment
There was a problem hiding this comment.
넘 멋있다잉~~~ playSplashBGM 메소드 부분 리뷰만 확인 부탁드려요!
Comment on lines
76
to
81
| func playSplashBGM() { | ||
| if let path = Bundle.main.path(forResource: "SplashBGM", ofType: "mp3") { | ||
| player = try? AVAudioPlayer(contentsOf: URL(fileURLWithPath: path)) | ||
| player?.volume = 0.8 | ||
| player?.play() | ||
| } |
Collaborator
There was a problem hiding this comment.
🐿️🐿️ View는 UI 구성에 집중하는 게 역할 분리에 더 적절하다고 생각합니다. 이런 기능은 ViewController 쪽에서 관리하면 책임이 더 명확해질 것 같아요. 어떻게 생각하시나요?
Contributor
Author
There was a problem hiding this comment.
fadeShadowImage와 함께 관리하고 싶어서 고민하다가 View에 넣었는데, 다시 생각해보니 둘 다 VC에 넣는 게 맞을 것 같네요 !! 감사합니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐿️ Pull Requests
🪵 작업 브랜치
🥔 작업 내용
2.0 스플래시 / 로그인 UI
🚨 참고 사항
📸 스크린샷
💥 To be sure
🌰 Resolve issue