[FEAT] 홈 - 장소이미지 없는 경우 UI, 비로그인 시 셀 잠금 기능 구현 (#135) #136
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements UI enhancements on the home screen by updating the BaseErrorView for configurable glassmorphism, refining the UI when an image fails to load, and adding cell overlay and login modal functionality for non-logged in users.
- Updated BaseErrorView to accept a style type and enable glassmorphism.
- Modified image loading in SpotListCollectionViewCell to display a "preparing images" view when needed.
- Added conditional login prompt overlay and modal presentation logic in SpotListViewController.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ACON-iOS/ACON-iOS/Presentation/SpotList/View/SpotListViewController.swift | Updated login cell overlay and tap handling based on user authentication. |
| ACON-iOS/ACON-iOS/Presentation/SpotList/View/SpotListView.swift | Modified error view instantiation to use the new style. |
| ACON-iOS/ACON-iOS/Presentation/SpotList/View/Cell/SpotListCollectionViewCell.swift | Added no-image and login error views; updated image loading error handling. |
| ACON-iOS/ACON-iOS/Presentation/Base/BaseErrorView.swift | Refactored to incorporate a style type and a configurable glass view. |
| ACON-iOS/ACON-iOS/Global/Utils/Enums/GlassmorphismType.swift | Added new glass types to support error view variations. |
| ACON-iOS/ACON-iOS/Global/Resources/Assets.xcassets/Images/2.0/img_skeleton_bg.imageset/Contents.json | Introduced a new skeleton background asset. |
| ACON-iOS/ACON-iOS/Global/Literals/StringLiterals.swift | Included new string literals for image preparation and login prompts. |
| ACON-iOS/ACON-iOS/Global/Literals/AmplitudeLiterals.swift | Updated with additional amplitude event names for the new interactions. |
| matchingRateBgColor: bgColor) | ||
| } | ||
|
|
||
| let showLoginCell = !AuthManager.shared.hasToken && indexPath.item > 4 |
There was a problem hiding this comment.
Consider extracting the magic number '4' into a clearly named constant to improve clarity and maintainability.
| let showLoginCell = !AuthManager.shared.hasToken && indexPath.item > 4 | |
| let showLoginCell = !AuthManager.shared.hasToken && indexPath.item > loginCellThreshold |
| case .success: | ||
| self.noImageErrorView.isHidden = true | ||
| case .failure(let error): | ||
| print("😢 이미지 로드 실패: \(error)") |
There was a problem hiding this comment.
[nitpick] Consider using a structured logging framework instead of print statements for error handling in production.
cirtuare
left a comment
cirtuare
left a comment
There was a problem hiding this comment.
좋아요좋아요 ~ 고생했어요 !
한 가지 고민되는 건, 네트워크 연결 실패 뷰가 달라짐에 따라 현재 baseErrorView는 홈에서만 사용되는 것으로 이해했는데 맞을까요:?? 그렇다면 homeErrorView라는 네이밍으로 변경하고 폴더링도 변경해도 괜찮을 것 같아요.
Base-가 붙으면 모든 에러 뷰가 baseErrorView를 따라야 할 것 같은 느낌이 들어서,, 한 번 고민해주세요 !!
그러네요! 꼼꼼히 봐주셔서 감사해요 🙌 |
Merge branch 'develop' into feature/#135
🐿️ Pull Requests
🪵 작업 브랜치
🥔 작업 내용
1. BaseErrorView 수정
2. 장소이미지 없는 경우 UI
서버 명세가 어떻게 될지 몰라, 일단은 KingFisher 이미지 변환에 실패한 경우, "이미지 준비 중" 뷰가 보여지도록 설정했습니다.
3. 비로그인 시 셀 잠금 기능
📸 스크린샷
ScreenRecording_05-12-2025.06-28-03_1.MP4
💥 To be sure
🌰 Resolve issue