Skip to content

Conversation

@yurim830
Copy link
Collaborator

@yurim830 yurim830 commented May 3, 2025

🐿️ Pull Requests

🪵 작업 브랜치

🥔 작업 내용

  • Extension methods
    • UIButton+ : 버튼에 글래스모피즘 배경을 설정하는 메소드를 구현했습니다.
    • UIImage+: 이미지 사이즈를 변경하는 메소드를 구현했습니다.
  • 추천장소 리스트 셀, 스크롤 인터렉션을 2.0버전에 맞게 수정했습니다.

📸 스크린샷

기능 스크린샷 기능 스크린샷
아이폰 16 Pro 아이폰 se

💥 To be sure

  • 모든 뷰가 잘 실행되는지 다시 한 번 체크해주세요 !

🌰 Resolve issue

@yurim830 yurim830 added 🌀 feature 새로운 기능 개발 🥑 유림 유림 labels May 3, 2025
@yurim830 yurim830 added this to the Sprint - 3 milestone May 3, 2025
@yurim830 yurim830 requested review from cirtuare and Copilot May 3, 2025 20:35
@yurim830 yurim830 self-assigned this May 3, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the SpotList screen for version 2.0 by enhancing the collection view scroll interaction and refreshing the cell UI components (e.g. buttons, images, and tags) while adding new extension methods.

  • Implemented a custom scroll snapping behavior via UIScrollViewDelegate.
  • Updated cell UI by replacing old matching rate views with new elements (titleLabel, acornCountButton, tagStackView, findCourseButton).
  • Adjusted sizing constants and introduced a custom collection view flow layout to support the new design.

Reviewed Changes

Copilot reviewed 13 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
SpotListViewController.swift Added scroll snapping behavior and updated header/footer sizes using updated sizing constants.
SpotListView.swift Replaced default layout with a custom flow layout and updated background colors/insets.
SpotListCollectionViewFlowLayout.swift Introduced a custom flow layout to support scaling and fading of off-center cells.
SpotTagButton.swift Implemented a new UIButton subclass with fixed layout and style for tag representation.
SkeletonView.swift Updated constraints to reflect new sizing using itemMaxWidth/itemMaxHeight and itemMinHeight.
SpotListCollectionViewHeader.swift Modified layout and text for the header to match the new design.
SpotListCollectionViewCell.swift Redesigned cell layout by removing legacy matching rate views and adding new UI elements.
SpotTagType.swift Updated tag type enum to support new tag formats.
SpotListItemSizeType.swift Updated size constants to reflect new design measurements.
ScreenUtils.swift Adjusted figmaHeight constant for screen ratio calculations.
StringLiterals.swift Updated and added new string literals for the revised UI text.
UIImage+.swift Added a new image resize extension.
UIButton+.swift Extended UIButton with a new method for applying a glassmorphism background.
Files not reviewed (3)
  • ACON-iOS/ACON-iOS.xcodeproj/project.pbxproj: Language not supported
  • ACON-iOS/ACON-iOS/Global/Resources/Assets.xcassets/Colors/tag_local.colorset/Contents.json: Language not supported
  • ACON-iOS/ACON-iOS/Global/Resources/Assets.xcassets/Colors/tag_new.colorset/Contents.json: Language not supported
Comments suppressed due to low confidence (2)

ACON-iOS/ACON-iOS/Presentation/SpotList/Type/SpotListItemSizeType.swift:16

  • [nitpick] Using a negative value for minimumLineSpacing is unconventional and might lead to unexpected layout behavior; please double-check that this value is intentional and aligns with the design requirements.
case minimumLineSpacing: return -20

ACON-iOS/ACON-iOS/Presentation/SpotList/View/Cell/SpotListCollectionViewCell.swift:125

  • [nitpick] Reusing the 'matchingRate' property to set the acorn count can be confusing; consider renaming this variable or using a dedicated property to more clearly represent its purpose.
if let acornCount = spot.matchingRate {

Copy link
Contributor

@cirtuare cirtuare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿굿 최고다 ~~

글모랑 버튼 관련해서 제 다음 피알에서 추상화를 잔뜩 해놔서 함 봐주세요!! (언제 올라갈지 모르지만,, ㅠㅠ,)

Comment on lines +90 to +91
let acorn: UIImage = .icAcornLine.resize(to: .init(width: 24, height: 24))
config.image = acorn
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐿️
config.preferredSymbolConfigurationForImage 로도 가능할 것 같은데 한 번 해보시겠어요?!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 메소드는 SFSymbols만 가능한 것 같아요..ㅜㅜ 아래처럼 임의로 40 넣어서도 해 봤는데 변화가 없네요..

            config.preferredSymbolConfigurationForImage = .init(pointSize: 40)
            config.image = .icAcornLine

Merge branch 'develop' into feature/#119
@yurim830 yurim830 merged commit 20ee2ec into develop May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🌀 feature 새로운 기능 개발 🥑 유림 유림

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEAT] 2.0 홈화면 컬렉션뷰 스크롤 인터렉션, 셀 UI 2.0 업데이트 (+Button, Image 메소드 구현)

3 participants