[SETTING] (Acon2.0) 스타일 업데이트 - 폰트, global 컴포넌트, 앱 아이콘 (#112) #114

yurim830 · 2025-04-27T14:24:30Z

🐿️ Pull Requests

🪵 작업 브랜치

[SETTING] (Acon2.0) 스타일 업데이트 - 폰트, global 컴포넌트, 앱 아이콘 (#112) #112

🥔 작업 내용

1. Deprecated 태그 처리

언어별로 kerning을 다르게 적용하기 용이한 형태로 struct를 새로 만들었습니다.
이로 인해 프로젝트 전반에 적용된 폰트를 일괄적으로 수정하기가 어려웠고, (2.0에서 수정될 뷰까지도 일일이 수정하는 건 리소스 낭비라 판단)
기존 스타일에 Deprecated 태그를 달아두고, 새로운 스타일을 만들었습니다.
@cirtuare 작업하시면서 Deprecated된 메소드를 사용하는 컴포넌트를 발견하실 때마다 새로 추가한 메소드로 변경해주시면 좋을 것 같습니다!

2. 언어별 다른 kerning 처리

한글은 -2.5%, 그 외는 0%로 설정되도록 했습니다.
적용된 곳: String.attributedString(_:_:), UILabel.setText(), UILabel.setLabel(), UILabel.setPartialText(), UIButton.setAttributedTitle(), UIButton.setPartialTitle()

3. Global Components 스타일 업데이트

NavigationBar, BaseErrorView, ACTextField, ACToast, LoginView와 같은 global 컴포넌트는 스타일 업데이트 해두었습니다.

4. 앱 아이콘 수정했습니다.

💥 To be sure

모든 뷰가 잘 실행되는지 다시 한 번 체크해주세요 !

🌰 Resolve issue

Resolved: [SETTING] (Acon2.0) 스타일 업데이트 - 폰트, global 컴포넌트, 앱 아이콘 (#112) #112

Merge branch 'develop' into setting/#112

This reverts commit 42cad15.

This reverts commit fd256de.

Copilot

Pull Request Overview

This PR updates the font styling throughout the project to reflect the changes from Acon 2.0.0, designating the old font APIs as deprecated and introducing new styling methods while updating related layout constraints. Key changes include replacing ACFont with OldACFont in various view and extension files, modifying layout constraints in LocalVerificationView, and introducing new methods supporting the updated ACFontType-based API.

Reviewed Changes

Copilot reviewed 27 out of 29 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
OnboardingViewController.swift	Replaced ACFont usages with OldACFont references in UI element styling.
SmallBoxViewCell.swift, LongBoxViewCell.swift, BigBoxViewCell.swift	Updated font styling to reference OldACFont for deprecated styles.
AnalyzingViewController.swift	Adjusted font styling in label configuration to use OldACFontStyleType.
LocalVerificationView.swift	Updated trailing constraint value and added contentHorizontalAlignment for button configuration.
BaseNavViewController.swift	Revised method signatures to incorporate OldACFontStyleType.
OldACFontStyle.swift	Deprecated ACFont and ACFontStyleType definitions in favor of new naming.
ACFontType.swift	Introduced new API for font styling.
UILabel+.swift, UIButton+.swift, String+.swift	Added new methods for styling labels, buttons, and strings using the new ACFontType API; deprecated methods using the old API now include warnings.
ACTextField.swift, Character+.swift, and others	Consistent updates replacing the old font definitions with their deprecated counterparts.

Files not reviewed (2)

ACON-iOS/ACON-iOS.xcodeproj/project.pbxproj: Language not supported
ACON-iOS/ACON-iOS/Global/Resources/Assets.xcassets/AppIcon.appiconset/Contents.json: Language not supported

Comments suppressed due to low confidence (1)

ACON-iOS/ACON-iOS/Presentation/LocalVerification/View/LocalVerificationView.swift:33

The trailing constraint has been changed from a computed value to a hardcoded constant (16); please confirm that this change aligns with the design requirements and does not negatively affect layout on different devices.

trailing: ScreenUtils.widthRatio*340-211)

Copilot · 2025-04-27T14:24:59Z

ACON-iOS/ACON-iOS/Global/Extensions/String+.swift

+            print("😡String+ Font lineHeight: \(style.fontStyle.lineHeight)")
+


This debug print statement appears to be left over from testing; consider removing it to avoid unintended logging in production.

Suggested change

print("😡String+ Font lineHeight: \(style.fontStyle.lineHeight)")

// (Line removed)

Copilot

Pull Request Overview

This pull request updates the font style system across the iOS project by deprecating the old ACFontStyleType and integrating the new ACFontType while also making various UI layout and style adjustments (including kerning updates and an updated app icon). Key changes include:

Replacing deprecated font styles with the new ACFontType (and related OldACFont for deprecated cases) in multiple view controllers and UI components.
Adjusting kerning values and layout constraints in error views, modal views, text fields, and buttons.
Refining string literals for UI copy consistency.

Reviewed Changes

Copilot reviewed 34 out of 38 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
Presentation/Base/BaseNavViewController.swift	Updated font style parameters and button titles from deprecated values to new ACFontType values.
Presentation/Base/BaseErrorView.swift	Adjusted layout constraints and replaced old font styles with updated font styles and colors.
Global/Utils/Enums/OldACFontStyle.swift	Renamed the old font style enum and marked it as deprecated for future removal.
Global/Utils/Enums/ACFontType.swift	Introduced the new ACFontType enum with updated font style definitions.
Global/Utils/Enums/ACFontStyleType.swift	Removed the deprecated ACFontStyleType file.
Global/UIComponents/LoginModal/View/LoginModalView.swift	Refactored font styles and layout properties for login modal components.
Global/UIComponents/CustomAlert/View/*.swift	Replaced font style usage with deprecated OldACFont for alert components.
Global/UIComponents/ACToastController.swift	Updated the toast view style from deprecated to new font style settings.
Global/UIComponents/ACTextField.swift	Changed the fontStyle property type and updated text field attributes accordingly.
Global/Literals/StringLiterals.swift	Revised UI text for clarity by removing an unnecessary line break and adjusting punctuation spacing.
Global/Extensions/*	Updated UILabel, UIButton, and String extensions to support both deprecated and new font style APIs.
Global/Extensions/Character+.swift	Added an extension to check for Korean characters used in kerning calculations.

Files not reviewed (4)

ACON-iOS/ACON-iOS.xcodeproj/project.pbxproj: Language not supported
ACON-iOS/ACON-iOS/Global/Resources/Assets.xcassets/AppIcon.appiconset/Contents.json: Language not supported
ACON-iOS/ACON-iOS/Global/Resources/Assets.xcassets/Icons/Basic 2.0/Contents.json: Language not supported
ACON-iOS/ACON-iOS/Global/Resources/Assets.xcassets/Icons/Basic 2.0/ic_clear.imageset/Contents.json: Language not supported

Copilot · 2025-04-27T17:02:21Z

ACON-iOS/ACON-iOS/Global/UIComponents/ACTextField.swift

            $0.defaultTextAttributes = [
-                .font: fontStyle.font,
-                .kern: fontStyle.kerning,
+                .font: ACFontType.t4(.semibold).fontStyle.font,


Using ACFontType.t4(.semibold) here overrides the intended instance property 'fontStyle'. Consider using the font from the 'fontStyle' property instead to respect the provided configuration.

Suggested change

.font: ACFontType.t4(.semibold).fontStyle.font,

.font: fontStyle.font,

ACON-iOS/ACON-iOS/Global/Literals/StringLiterals.swift

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge branch 'setting/#112' of https://github.com/TeamACON/ACON-iOS into setting/#112

cirtuare

굿잡굿잡 체고다 !!!!

그리고 혹시 Global>Resources>Fonts에 있는 Pretendard-Medium 삭제해주실 수 있나요??

cirtuare · 2025-04-28T15:01:59Z

ACON-iOS/ACON-iOS/Global/Extensions/String+.swift

+    enum Language {
+        case korean
+        case other
+    }


🐿️🐿️
요건 Global>Enums에 LanguageType으로 넣고, String extension을 다시 하나의 extension으로 합치는 건 어떤가요? 나누는 게 불필요할 수 있을 것 같아 말씀드립니다 !

반영했습니다!

yurim830 added 9 commits April 22, 2025 03:32

[Setting] gitignore에 env.default 추가 (#112)

4db3f80

[Chore] 브랜치 최신화 (#112)

ecbc1b7

Merge branch 'develop' into setting/#112

[Refactor] (v2.0.0) 폰트 스타일 수정 (폰트 weight를 파라미터로) (#112)

cb34154

[Add, Feat] (Character+) 한글 판별 computed property 구현 (#112)

42cad15

Revert "[Add, Feat] (Character+) 한글 판별 computed property 구현 (#112)"

fd256de

This reverts commit 42cad15.

Reapply "[Add, Feat] (Character+) 한글 판별 computed property 구현 (#112)"

e9db478

This reverts commit fd256de.

[Feat] (v2.0.0) 폰트 스타일, String+, Label+, Button+ 메소드 생성 (#112)

80c3478

[Chore] 이전 폰트, string+, label+, button+ 메소드에 deprecated 달기 (#112)

230f16d

[Add,Delete] 앱 아이콘 변경 (#112)

918041d

yurim830 added ⚙️ setting 세팅 🥑 유림 유림 labels Apr 27, 2025

yurim830 added this to the Sprint - 3 milestone Apr 27, 2025

yurim830 requested review from cirtuare and Copilot April 27, 2025 14:24

yurim830 self-assigned this Apr 27, 2025

[Chore] 메소드명 수정 (#112)

4a564b6

Copilot AI reviewed Apr 27, 2025

View reviewed changes

yurim830 added 11 commits April 27, 2025 23:36

[Chore] 메소드 배치 변경 (#112)

c65c7da

[Chore] 디버깅 프린트 삭제, 누락된 deprecated 태그 추가 (#112)

b94ff97

[Chore] gitignore 복구 (/env.default 삭제) (#112)

fd46f15

[Chore] 빈 줄 삭제 (#112)

c59d3c2

[Chore] BaseNavVC 폰트스타일 업데이트 (#112)

a969a50

[Chore] BaseErrorView 스타일 업데이트 (#112)

5fedf55

[Chore] ACTextField 스타일 업데이트 (#112)

e2d07a7

[Chore] ACToast 스타일 업데이트 (#112)

9c66c08

[Chore] LoginView, ModalView 스타일 업데이트 (#112)

fe0a496

[Chore] 코드 정리 (#112)

050897b

[Chore] 로그인뷰 레이아웃 깨진 것 수정, 폰트 bold 삭제 (#112)

5b46294

yurim830 requested a review from Copilot April 27, 2025 17:01

Copilot AI reviewed Apr 27, 2025

View reviewed changes

[Chore] StringLiterals 스페이스 추가 (#112)

2c6b552

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

yurim830 changed the title ~~[SETTING] 폰트스타일 업데이트, 앱 아이콘 변경 (#112)~~ [SETTING] (2.0) 스타일 업데이트 - 폰트, global 컴포넌트, 앱 아이콘 (#112) Apr 28, 2025

yurim830 added 4 commits April 28, 2025 23:25

[Refactor] 폰트 weight 설정 방식 수정: .h1(.semibold) -> .h1SB

38c8ab3

[Chore] 깃헙 수정사항 pull

cf53acf

Merge branch 'setting/#112' of https://github.com/TeamACON/ACON-iOS into setting/#112

[Chore] 줄바꿈 (#112)

7580ea7

[Chore] 메소드명 수정 (#112)

e64f6da

cirtuare approved these changes Apr 28, 2025

View reviewed changes

[Chore] 폰트 파일 및 info.plist 수정, LanguageType 분리, String+ 코리 반영 (#112)

1ae3fef

yurim830 merged commit f46b34d into develop Apr 28, 2025

yurim830 changed the title ~~[SETTING] (2.0) 스타일 업데이트 - 폰트, global 컴포넌트, 앱 아이콘 (#112)~~ [SETTING] (Acon2.0) 스타일 업데이트 - 폰트, global 컴포넌트, 앱 아이콘 (#112) Apr 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SETTING] (Acon2.0) 스타일 업데이트 - 폰트, global 컴포넌트, 앱 아이콘 (#112) #114

[SETTING] (Acon2.0) 스타일 업데이트 - 폰트, global 컴포넌트, 앱 아이콘 (#112) #114

Uh oh!

yurim830 commented Apr 27, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 27, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 27, 2025

Uh oh!

Uh oh!

cirtuare left a comment

Uh oh!

cirtuare Apr 28, 2025 •

edited

Loading

Uh oh!

yurim830 Apr 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		print("😡String+ Font lineHeight: \(style.fontStyle.lineHeight)")

	print("😡String+ Font lineHeight: \(style.fontStyle.lineHeight)")

	// (Line removed)

	.font: ACFontType.t4(.semibold).fontStyle.font,
	.font: fontStyle.font,

[SETTING] (Acon2.0) 스타일 업데이트 - 폰트, global 컴포넌트, 앱 아이콘 (#112) #114

[SETTING] (Acon2.0) 스타일 업데이트 - 폰트, global 컴포넌트, 앱 아이콘 (#112) #114

Uh oh!

Conversation

yurim830 commented Apr 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🐿️ Pull Requests

🪵 작업 브랜치

🥔 작업 내용

1. Deprecated 태그 처리

2. 언어별 다른 kerning 처리

3. Global Components 스타일 업데이트

💥 To be sure

🌰 Resolve issue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Apr 27, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Apr 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cirtuare left a comment

Choose a reason for hiding this comment

Uh oh!

cirtuare Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yurim830 Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yurim830 commented Apr 27, 2025 •

edited

Loading

cirtuare Apr 28, 2025 •

edited

Loading