Skip to content

Comments

fix(lsp): show clear error when Terminal is not installed#1900

Merged
bajrangCoder merged 2 commits intoAcode-Foundation:mainfrom
bajrangCoder:fix/lsp-terminal-install-check
Feb 25, 2026
Merged

fix(lsp): show clear error when Terminal is not installed#1900
bajrangCoder merged 2 commits intoAcode-Foundation:mainfrom
bajrangCoder:fix/lsp-terminal-install-check

Conversation

@bajrangCoder
Copy link
Member

No description provided.

@github-actions github-actions bot added the translations Anything related to Translations Whether a Issue or PR label Feb 25, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 25, 2026

Greptile Summary

Added Terminal installation check before launching LSP servers to prevent cryptic errors when Terminal plugin is missing.

Critical Issue:

  • Module-level access to strings.terminal_required_message_for_lsp at line 28 of serverLauncher.ts will fail because the global strings object is initialized asynchronously during app startup in main.js, but this constant is evaluated immediately when the module is imported

Translation Issues:

  • All 31 non-English language files use English text instead of native translations, which defeats the purpose of i18n for this error message

Confidence Score: 1/5

  • This PR will cause a runtime error when serverLauncher.ts is first imported
  • The module-level constant TERMINAL_REQUIRED_MESSAGE tries to access strings.terminal_required_message_for_lsp before the global strings object is initialized, which will cause an error or return undefined. This is a critical bug that prevents the feature from working.
  • src/cm/lsp/serverLauncher.ts requires immediate fix for the module-level strings access issue

Important Files Changed

Filename Overview
src/cm/lsp/serverLauncher.ts Added Terminal installation check before LSP server launch, but strings access at module-level (line 28) will cause runtime error
src/lang/en-us.json Added terminal_required_message_for_lsp translation key
src/lang/ar-ye.json Added translation key but uses English text instead of Arabic translation
src/lang/de-de.json Added translation key but uses English text instead of German translation
src/lang/fr-fr.json Added translation key but uses English text instead of French translation
src/lang/zh-cn.json Added translation key but uses English text instead of Chinese Simplified translation

Last reviewed commit: 7ee4deb

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@bajrangCoder bajrangCoder merged commit a338012 into Acode-Foundation:main Feb 25, 2026
6 checks passed
@bajrangCoder bajrangCoder deleted the fix/lsp-terminal-install-check branch February 25, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

translations Anything related to Translations Whether a Issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant