Skip to content

style(ci): Replace unnecessary \ns in nightly release message#1627

Merged
UnschooledGamer merged 1 commit intoAcode-Foundation:mainfrom
1Code-JS:ci-nightly-release-message-fix
Oct 6, 2025
Merged

style(ci): Replace unnecessary \ns in nightly release message#1627
UnschooledGamer merged 1 commit intoAcode-Foundation:mainfrom
1Code-JS:ci-nightly-release-message-fix

Conversation

@peasneovoyager2banana2
Copy link
Contributor

Screenshot_20251006-164430_Chrome Beta Screenshot_20251006-164627_GitHub

UnschooledGamer added a commit to UnschooledGamer/Acode that referenced this pull request Oct 6, 2025
@UnschooledGamer UnschooledGamer merged commit 2b5ebcf into Acode-Foundation:main Oct 6, 2025
2 checks passed
@peasneovoyager2banana2 peasneovoyager2banana2 deleted the ci-nightly-release-message-fix branch October 6, 2025 16:59
UnschooledGamer added a commit that referenced this pull request Oct 8, 2025
…ll_request. (#1628)

* refactor(On-demand-Builds-CI)!: use pull_request_target instead of pull_request.

Important: `pull_request_target` makes the `on-demand-preview-releases-PR.yml` run from base repository with secrets and gives read/write permissions to `$GITHUB_TOKEN` (`secrets.GITHUB_TOKEN`). Unlike normal `pull_request` trigger that has explicit read-ONLY permissions for `$GITHUB_TOKEN`. Meaning secrets and permissions SHOULD BE NOW handled strictly!

Changes:

- checkout `${{ github.event.pull_request.head.sha }}` & sets `persist-credentials: false` to not persist tokens in local git config.
- Adds `skip_tagging_and_releases` input for nightly-build.yml Manual Runs (default: true)
- Adds `CODEOWNERS` file to protect nightly builds and on demand workflows, preventing pushes in PRs without reviews from Authors of the workflow.

* chore: remove `\n\n` from nightly release notes.

* revert(nightly-build): partial file - 2c37532

Revert: 2c37532

for: #1628 (comment) ( @peasneovoyager2banana2) as they did #1627 before. 
With All Respect!

* add(nightly-build): ref & persist-credentials
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants