Skip to content

fix: cors related issues when installing plugins from remote#1246

Merged
bajrangCoder merged 1 commit intoAcode-Foundation:mainfrom
bajrangCoder:fix-remote-cors-issue
Apr 8, 2025
Merged

fix: cors related issues when installing plugins from remote#1246
bajrangCoder merged 1 commit intoAcode-Foundation:mainfrom
bajrangCoder:fix-remote-cors-issue

Conversation

@bajrangCoder
Copy link
Member

No description provided.

@bajrangCoder bajrangCoder requested a review from Copilot April 8, 2025 12:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/lib/installPlugin.js:70

  • Using 'includes' for checking API_BASE might lead to false positives if the intended API_BASE value appears as a substring in unexpected URL contexts. Consider using a more robust URL comparison or parsing method to ensure correct matching.
if (pluginUrl.includes(constants.API_BASE)) {

src/lib/installPlugin.js:69

  • The removal of the IP address and localhost check may impact cases where plugins are referenced by IP or localhost. Verify that these scenarios are intentionally handled by the new logic without any regressions.
if (/^(https?:\/\/)?(\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}|localhost)/.test(pluginUrl)) {

@bajrangCoder bajrangCoder merged commit 89e1320 into Acode-Foundation:main Apr 8, 2025
2 checks passed
@bajrangCoder bajrangCoder deleted the fix-remote-cors-issue branch April 8, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants