Skip to content

Refactor Iap.java: Use WeakReference for Context and Activity to prevent memory leaks #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bajrangCoder merged 3 commits into from
Oct 6, 2024
Merged

Refactor Iap.java: Use WeakReference for Context and Activity to prevent memory leaks #1040

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4d4f7e4
Create android.yml
ThDev-only Sep 28, 2024
6d6aeea
Delete .github/workflows/android.yml
ThDev-only Sep 28, 2024
bff7d6e
chore: prevent memory leaks in Iap.java by using WeakReference for Co…
ThDev-only Sep 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/plugins/iap/src/com/foxdebug/iap/Iap.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.lang.ref.WeakReference;
import org.apache.cordova.CallbackContext;
import org.apache.cordova.CordovaInterface;
import org.apache.cordova.CordovaPlugin;
Expand All @@ -35,14 +36,14 @@
public class Iap extends CordovaPlugin {

private BillingClient billingClient;
private Context context;
private Activity activity;
private WeakReference<Context> contextRef;
private WeakReference<Activity> activityRef;
private CallbackContext purchaseUpdated;

public void initialize(CordovaInterface cordova, CordovaWebView webView) {
super.initialize(cordova, webView);
context = cordova.getContext();
activity = cordova.getActivity();
contextRef = new WeakReference<>(cordova.getContext());
activityRef = new WeakReference<>(cordova.getActivity());
billingClient = getBillingClient();
}

Expand Down Expand Up @@ -103,7 +104,7 @@ public void run() {

private BillingClient getBillingClient() {
return BillingClient
.newBuilder(this.context)
.newBuilder(this.contextRef.get())
.enablePendingPurchases()
.setListener(
new PurchasesUpdatedListener() {
Expand Down Expand Up @@ -248,7 +249,7 @@ private void purchase(String json, CallbackContext callbackContext) {
try {
SkuDetails skuDetails = new SkuDetails(json);
BillingResult result = billingClient.launchBillingFlow(
activity,
activityRef.get(),
BillingFlowParams.newBuilder().setSkuDetails(skuDetails).build()
);
int responseCode = result.getResponseCode();
Expand Down